-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customizable _startTokenId()
and _totalMinted()
(Continued from #66)
#129
Conversation
…sts for it more elaborate.
Feature/start index + Burnable
…rk with recent changes on `main`
_startTokenId() + _totalMinted()
_startTokenId()
and _totalMinted()
_startTokenId()
and _totalMinted()
(Continued from #66)
Thanks for opening this PR. My opinion about suggestions:
Agree to use prettier for both
I opened a PR before about adding
Using |
Continued from #66. Kept the history of commits to preserve contributions.
Summary:
_startTokenId()
to be customized via function override.maxBatchSize
.Not a problem as we only support >= 0.8.4.
_totalMinted()
function. See feat:_totalMinted()
function. #124README
to tell people to use_totalMinted()
.Some quality of life suggestions (not yet added), please drop your opinions below
(include it in this PR / move to future PR / not needed / etc.):
But that doesn't mean we can't prettify things a bit.
_mint(to, quantity)
function.This for the
README
example._safeMint
that it is not re-entrancy safe, and encourage users to use_mint
instead?This is for the
README
example.Many projects are using ERC721A. Many of which are not listed.
Our contributions do have a huge impact, probably more than we can imagine.
@cygaar @ahbanavi @Pczek