Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _unsafeMint function #86

Closed
wants to merge 2 commits into from
Closed

add _unsafeMint function #86

wants to merge 2 commits into from

Conversation

ahbanavi
Copy link
Contributor

@ahbanavi ahbanavi commented Feb 9, 2022

For easier use so that we do not have to fill all 4 parameters.
I think with that way, mocking and testing _mint function is redundant, let me know if it did, so I remove related tests.

Also, I think _mint function should be private instead of internal cause with _safeMint and _unsafeMint functions there's no additional need for developers to use this method directly. I wait to hear other's opinion about this.

I will add testGas tests after I figure out whether we should make _mint function internal or make it private. Also, there are some bugs in test/GasUsage.test.js context names, I'm not sure to fix them in this PR or make another.

@syffs
Copy link

syffs commented Feb 9, 2022

I don't think it's worth adding a wrapper around _mint function (which is going to add more gas on the deployment) for the reasons you mentioned

@cygaar
Copy link
Collaborator

cygaar commented Feb 9, 2022

Agree with @syffs here, don't think this adds too much value, and I prefer not to add more code just to save on adding in two parameters to a function call

@ahbanavi
Copy link
Contributor Author

ahbanavi commented Feb 9, 2022

Makes sense, I open another PR later for fixes on test/GasUsage.test.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants