Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For easier use so that we do not have to fill all 4 parameters.
I think with that way, mocking and testing
_mint
function is redundant, let me know if it did, so I remove related tests.Also, I think
_mint
function should beprivate
instead ofinternal
cause with_safeMint
and_unsafeMint
functions there's no additional need for developers to use this method directly. I wait to hear other's opinion about this.I will add testGas tests after I figure out whether we should make
_mint
function internal or make it private. Also, there are some bugs in test/GasUsage.test.js context names, I'm not sure to fix them in this PR or make another.