Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chocolatey Install script updates #7

Closed
4 tasks done
ferventcoder opened this issue Jan 7, 2015 · 0 comments
Closed
4 tasks done

Chocolatey Install script updates #7

ferventcoder opened this issue Jan 7, 2015 · 0 comments

Comments

@ferventcoder
Copy link
Member

There are a few things we need to do:

  • automatically update the path to the default path
  • update redirects shims
  • update the path in env:PATH
  • warn when install is not run in administrative mode - especially surrounding creation of environment variables
  • set permissions on log folder
@ferventcoder ferventcoder added this to the 0.9.9 milestone Jan 7, 2015
@ferventcoder ferventcoder self-assigned this Jan 7, 2015
ferventcoder added a commit that referenced this issue Jan 17, 2015
Install Chocolatey to the machine or upgrade an existing Chocolatey
installation.

 * Automatically upgrade the old default path of c:\chocolatey to
programdata
 * Update/Remove old ChocolateyInstall variables no matter which side
they are on (prior to updating)
 * Remove old chocolatey install from either user or machine path if it
exists.
ferventcoder added a commit that referenced this issue Jan 17, 2015
- Bring only the bin/lib directories from old location
- Rerun Install-ChocolateyBinFiles to ensure files are copied
- Leave the chocolateyinstall\*.log files so that errors don't bring
the upgrade to a halt
ferventcoder added a commit that referenced this issue Jan 18, 2015
In the bin directory there may be old files that need to be removed. Do
not fail when removing those files.
gep13 added a commit to gep13/choco that referenced this issue Jan 18, 2015
* upstream/master:
  (chocolateyGH-21) Don't publish Nuget pkgs for PRs
  (chocolateyGH-21) fix nupkg inclusion
  (chocolateyGH-21) appveyor artifacts do not allow wildcards
  (doc) Submitting issues enhancements
  (chocolateyGH-21) change notification subject
  (chocolateyGH-21)(doc) Add build status email group
  (chocolateyGH-21) gather nupkgs as artifacts
  (chocolateyGH-21) set clone depth to 5
  (chocolateyGH-21) AppVeyor Build status only master branch
  (doc) readme - add links / fixup header
  (doc) Add badges
  (chocolateyGH-21) AppVeyor - set git config options globally
  (chocolateyGH-21) AppVeyor tweaks
  (chocolateyGH-21) Add initial AppVeyor configuration
  (log) list command escape curly braces
  (chocolateyGH-7) do not fail when deleting .old files
  (convention) methods/properties/events to inspect
  (doc) Help menu enhancements
ferventcoder added a commit that referenced this issue Feb 4, 2015
It could be that there are two running instances of choco going at the
same time during upgrade scenarios, so throwing a fatal error
would be a bad thing.
ferventcoder added a commit that referenced this issue Feb 4, 2015
- Write more debugging messages during installation process.
- In cases where it doesn't matter if something fails, silently
continue instead of stopping the install/upgrade.
ferventcoder added a commit that referenced this issue Feb 4, 2015
Instead of the client profile as folks have reported issues with the
client profile being installed (for other things). Better to take the
additional few megabyte hit of the full framework install to alleviate
any issues.
ferventcoder added a commit that referenced this issue Feb 8, 2015
When set in debug mode, unpackself should also be called with `-dv`
ferventcoder added a commit that referenced this issue Feb 8, 2015
* stable:
  (GH-7) install - unpacking log debut output
  (GH-78) Unpack self should use relative directory
@ferventcoder ferventcoder changed the title Installation updates Chocolatey Install script updates Feb 11, 2015
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 12, 2015
If the environment variables are being created as USER instead of
SYSTEM, warn the user about this so they can take manual actions if
this is not what they wanted.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 12, 2015
The environment variable may exist, better to check for the explicit
value of true.
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 12, 2015
On upgrade, split the old folder copying from the old folder removal
since the removal is likely to throw errors, we want to give the
message that choco is installed successfully, then attempt to remove
the old folder (which is highly likely to throw errors).
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 12, 2015
* stable:
  (version) 0.9.9-rc6
  (chocolateyGH-7) Upgrade improvements
  (chocolateyGH-99) Warn when admin is not elevated
  (log) update what confirm (`-y`) does
  (chocolateyGH-82) Set Modify for Installing User
  (chocolateyGH-91) Terminating errors - choco upgrade fail
  (chocolateyGH-7) Check debug env var for 'true'
  (maint) fix logging message
  (chocolateyGH-97) Noop shows number of upgrades available
  (chocolateyGH-91) Remove global ErrorActionPreference Stop
  (command) accept features as alias
  (chocolateyGH-7) warn when install is not done in admin mode
  (doc) add changelog for 0.9.8.33
  (posh) dynamically export helpers
  (chocolateyGH-87) Backup improvements
  (chocolateyGH-94) Remove rollback on success
  (chocolateyGH-87) shorten rollback suffix
  (chocolateyGH-93) Avoid CS0200 Serialization w/private set
  (chocolateyGH-92) PowerShell - handle spaces in module path
  (shimgen) Fix company name on shims
ferventcoder added a commit that referenced this issue Feb 13, 2015
Attempt to remove each item from folders and leave around old log files.

If redirects path doesn't exist, warn and move on (scenario: Upgrade
from c:\chocolatey to new folder structure and location)
ferventcoder added a commit that referenced this issue Feb 13, 2015
* stable:
  (version) 0.9.9-rc7
  (GH-7)(GH-91) upgrade should work with posh v2
  (GH-7) Do not reinstall bin files if no old path
  (GH-7) MOAR debug in install script
  (doc) Core lib is preview
  (GH-82) Do not state name of user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants