Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnpackSelf should always use relative directory. #78

Closed
ferventcoder opened this issue Feb 8, 2015 · 0 comments
Closed

UnpackSelf should always use relative directory. #78

ferventcoder opened this issue Feb 8, 2015 · 0 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Priority_HIGH
Milestone
0.9.9

Comments

@ferventcoder
Copy link
Member

Unpackself was using ApplicationInstall which used to be pointed to relative path but was changed in 8555f57 to search for the ChocolateyInstall environment variable recently for the dll to use the same install as the exe, if it exists. Unfortunately doing that has caused a bug in the installer as it was looking at relative path.

The bug is actually in unpackself as it should always look at the path relative to where choco.exe is located.
@ferventcoder ferventcoder self-assigned this Feb 8, 2015
@ferventcoder ferventcoder added this to the 0.9.9 milestone Feb 8, 2015
ferventcoder added a commit that referenced this issue Feb 8, 2015
@ferventcoder
(GH-78) Unpack self should use relative directory
889906a 
Using ApplicationParameters.InstallLocation will use the
global chocolatey install path, which can lead to undesired behavior.
ferventcoder added a commit that referenced this issue Feb 8, 2015
@ferventcoder
Merge branch 'stable'
6ab6f8d 
* stable:
  (GH-7) install - unpacking log debut output
  (GH-78) Unpack self should use relative directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Priority_HIGH
Projects
None yet
Milestone
0.9.9
Development

No branches or pull requests
2 participants
@ferventcoder @gep13