Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get-UninstallRegistryKey fixes/improvements #815

Closed
5 tasks done
dtgm opened this issue Jun 19, 2016 · 2 comments
Closed
5 tasks done

Get-UninstallRegistryKey fixes/improvements #815

dtgm opened this issue Jun 19, 2016 · 2 comments
Assignees
@ferventcoder
Labels
5 - Released Bug Improvement
Milestone
0.10.4

Comments

@dtgm
Copy link
Contributor

dtgm commented Jun 19, 2016 •
edited
Loading

Fixes
  • 1. Not building array properly; fails if more than one bad key
  • 2. Not reporting correct key
Changes -- proposed
  • 1. (logic) Remove limit on bad keys, but
  • 2. (reporting) ^^^ add warning about possibly corrupted registry if many are found.
  • 3. (reporting) write-verbose if no registry keys matched SoftwareName
dtgm added a commit to dtgm/choco that referenced this issue Jun 19, 2016
@dtgm
(chocolateyGH-815) fixes 1 and 2
299e0dc
dtgm added a commit to dtgm/choco that referenced this issue Jun 19, 2016
@dtgm
(chocolateyGH-815) Changes 1,2,3
22bf42a 
1. (logic) Remove limit on bad keys, but
2. (reporting) ^^^ add warning about possibly corrupted registry if >10 are found.
3. (reporting) write-debug with number of keys matched
dtgm added a commit to dtgm/choco that referenced this issue Jun 19, 2016
@dtgm
(chocolateyGH-815) changes 2 (previous commit did not include
e704fc9 
(reporting) ^^^ add warning about possibly corrupted registry if many are found.
@dtgm dtgm mentioned this issue Jun 25, 2016
Closed
@gep13
Copy link
Member

gep13 commented Jun 25, 2016

I have just merged this into the repository, and am away to push the new version of the package.

@gep13
Copy link
Member

gep13 commented Jun 25, 2016

And pushed...

@dtgm dtgm mentioned this issue Mar 18, 2017
Closed
@ferventcoder ferventcoder self-assigned this Mar 18, 2017
@ferventcoder ferventcoder added this to the 0.10.4 milestone Mar 18, 2017
ferventcoder pushed a commit that referenced this issue Mar 18, 2017
@dtgm @ferventcoder
(GH-815) Get-UninstallRegistryKey fixes/enhancements
249dcdf 
- optimize registry search to only get keys once
- remove limit on bad keys
- add warning about possible corrupted registry if >10 bad keys are found
- note in debugging how many keys matched
ferventcoder added a commit that referenced this issue Mar 18, 2017
@ferventcoder
Merge branch 'pr816' into stable
322b4eb 
* pr816:
  (GH-815) Get-UninstallRegistryKey fixes/enhancements
ferventcoder added a commit that referenced this issue Mar 18, 2017
@ferventcoder
Merge branch 'stable'
2ab0b96 
* stable:
  (GH-815) Get-UninstallRegistryKey fixes/enhancements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferventcoder ferventcoder

Labels
5 - Released Bug Improvement
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @dtgm