Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move supported views array to file #147

Merged
merged 2 commits into from
Apr 26, 2019
Merged

Conversation

ungoldman
Copy link
Member

Tried moving supported views array to file as suggested in #146 (comment)

One thing worth noting: in lib/browserify-transform.js, choo is included in the list, whereas in babel.js it is not. My feeling is that it's not needed (choo/html is included in both), but I'd like confirmation of this from a maintainer before moving forward.

cc @goto-bus-stop

@ungoldman
Copy link
Member Author

Tests suggest my assumption was wrong :)

Will take another look later, as I'm on a desert island for a week! Please feel free to correct my PR and merge it in my absence. May just be that adding choo back does the trick.

@goto-bus-stop
Copy link
Member

I believe the 'choo' entry was intended for old choo, when you'd do

choo.view`<div />`

@goto-bus-stop
Copy link
Member

aye, enjoy the island :D i will add it back for now, we can remove it in a major release though

@goto-bus-stop goto-bus-stop merged commit 09608d8 into master Apr 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the supported-views branch April 26, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants