ustream: fix desktop stream validation #1227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The validation changes in #1126 aren't strict enough, there are now more than 1 unexpected streams that we can't read, and they do not all contain the varnishUrl key.
|
I think this should also fix whatever the problem was in #1226 although I wasn't able to reproduce the issue for that ustream URL (http://www.ustream.tv/siliconangle) should also resolve remaining the non-windows specific problems in #1122 |
|
Works great for me, thanks for the patch (tested it locally) |
|
Works for me as well. Thank you, @pmrowla. |
Closed
|
no point in keeping this open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more than 1 unexpected streams that we can't read, and they do not all
contain the varnishUrl key.