-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposed fixes 1.13 #1495
Proposed fixes 1.13 #1495
Conversation
…hen it is really a float
- The validation changes in #1126 aren't strict enough, there are now more than 1 unexpected streams that we can't read, and they do not all contain the varnishUrl key.
Fixes #1171
Livestreamer wouldn't recognise the Periscope url, because the url schema has changed.
NRK has done some changes to their streaming services which broke the plugin. Playlist URL is now fetched via an API call, whose URL is embedded in the webpage.
Also removed unused _program_id regex.
- Make use of new API while keeping the old method as backup
use new api
@javiercantero could you open this PR in streamlink? We'd be happy to take those fixes. |
@sbstp Seems that the GitHub interface doesn't allow me to create a PR from my repo to the streamlink repo. Edit: the problem is that the streamlink repository is not listed as a fork of livestreamer. Have you guys pushed it directly from a local git repo instead of using the GH fork button? |
You could try somethin from this site @javiercantero http://stackoverflow.com/questions/1425892/how-do-you-merge-two-git-repositories |
@Erk- Finally I've done it by forking the streamlink repository and using the forked repo as a proxy. But there is a serious divergence between the streamlink branch (based on chrippa's master branch) and mine (based on chrippa's develop branch). And try to merge these branches is going to be a PITA /cc @sbstp |
Can you post a build in case this will never be seen by the author? |
@vadosnaprimer A build like executables for Win/Mac? I can't, I don't use any of those environments. |
Running If you're not on Windows, I believe you should be able to build and install yourself using |
Sorry for being a noob, but can anyone tell me how I install these fixes? |
@NuMs1 You should look at Streamlink which is a fork of livestreamer. |
@NuMs1 If you are asking about using it in Windows, in the @mjbcopland's message just above your comment there is a build ready to install. But as @Erk- has pointed out, it's better if you use the new project Streamlink since it's maintained. |
Unfortunately
edit: It seems that more research is needed to get an appropriate response from the server to fix this. It seems to make an appropriate call but then somewhere in the plugin it makes an HTTP call that has an empty body and response 200. That's where it breaks, since it expects a body with more required data. edit 2: turns out it's a super quick fix. In
This allows URLs from embeds to work as well. This is a quick fix to get vaughnlive working again. The seem to continuously change the first few letters in minor ways to throw streaming software off. |
Request for closing this one. Seems to be a leftover. |
Ok. @int3l, closing it. |
This is a compilation of 19 pending pull requests by 18 contributors to
be applied to the lastest version of chrippa's develop branch (commit
ab80dbd on 2 Feb 2016) in order to fix 14 plugins of livestreamer. It
neither includes new code nor new plugins, only fixes to existing
plugins.
@mindhalt) (Fixes: Twitch Oauth not possible due to 404 #1306 livestreamer --twitch-oauth-authenticate - "SORRY This page does not exist yet." #1341 Trying to generate a twitch oauth token with --twitch-oauth-authenticate leads to a 404 page #1385)
(Fixes: 'Best' quality no longer works with newest Twitch quality format #1433)
(Fixes: Client-ID required for all twitch API calls in future #1407 Twitch API changes? #1456 Twitch - Unable to open URL #1478)
(Fixes: livestream.com stop working #1272 Livestream.com plugin broken, returns 404 for hdplayer-2.0-viewerplus.swf #1318 Livestream.com #1422 Livestream.com URL Not Working Anymore #1465)
(Fixes: Plugin Ustream.tv : Unable to fetch desktop streams #1122)
merge commit— by @bvklim and @snifer1981) (Fixes: ustream.py has error on update_chunk_info #1171 Ustream plugin Again not working #1226
Nightly build returning URL KeyError (uStream) #1276 Urgent Problem: No streams found on this url : http://www.ustream.tv/channel/orocoipo #1388 issue with ISS urlstream #1389 Ustream "no streams found on this URL" previously working #1415)
@AleXoundOS) (Fixes AfreecaTV service changed,plugin fixed. #1374 Does not work with Afreeca #1416)
(Fixes: streamupcom.py plugin not working #1218 Streamup.com no longer works? #1256 streamup.com is no longer working again #1293)
The tga plugin not working with certian streams #1208 [error] longzhuTV #1285 tga plugin for longzhu not working??? #1344)
@michaelnachname) (Fixes: Feature request: persicope: support https://www.periscope.tv/username/broadcastID #1070 Livestreamer indicates "unable to open URL" and "client error : bad request" #1175)
Unable to parse JSON - Svtplay #1258)
(Fixes: Vaughnlive plugin response length validation #1370 vaughnlive FIX #1373 vaughnlive plugin problem #1379 vaughnlive no data returned from stream #1413 vaughnlive down #1443 vaughnlive "error: Unable to validate response text: Minimum length is 3 but value is 1" #1445 vaughnlive.tv new INFO_URL #1497)
by @int3l)
(Fixes: Picarto - [cli][error] No data returned from stream #1419 picarto plugin is broken: [cli][error] No data returned from stream #1468)