Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unicorn/better-regex ESLint rule #1055

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

codykaup
Copy link
Contributor

@codykaup codykaup commented Sep 23, 2024

Simply enables our unicorn/better-regex ESLint rule and fixes any errors that appear.

📦 Published PR as canary version: 11.10.3--canary.1055.10997453293.0

✨ Test out this PR locally via:

npm install chromatic@11.10.3--canary.1055.10997453293.0
# or 
yarn add chromatic@11.10.3--canary.1055.10997453293.0

@codykaup codykaup self-assigned this Sep 23, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 66.67% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e39417c) 8336 4480 53.74%
Head commit (ab21fb0) 8336 (+0) 4480 (+0) 53.74% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1055) 6 4 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@codykaup codykaup added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Sep 23, 2024
Copy link
Contributor

📦 Package Size: 4180 KB

@codykaup codykaup requested a review from a team September 23, 2024 15:28
@codykaup codykaup added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 1373371 Sep 23, 2024
23 of 26 checks passed
@codykaup codykaup deleted the cody/cap-2223-enable-unicornbetter-regex branch September 23, 2024 16:20
@ghengeveld
Copy link
Member

🚀 PR was released in v11.10.4 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants