-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect context.projectMetadata.hasRouter
and send to the index
#1112
Detect context.projectMetadata.hasRouter
and send to the index
#1112
Conversation
📦 Package Size: 5380 KB |
I plan to add some other fields to |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
e810edd
to
b338a3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good other than the placement of setting ctx.projectMetadata
!
🚀 PR was released in |
This PR is blocked on an index change (to come).
To QA:
hasRouter=true
react-vite
Sandbox)hasRouter=false
Use this review app: https://github.com/chromaui/chromatic/pull/9061
📦 Published PR as canary version:
11.19.0--canary.1112.11732911724.0
✨ Test out this PR locally via:
npm install chromatic@11.19.0--canary.1112.11732911724.0 # or yarn add chromatic@11.19.0--canary.1112.11732911724.0