Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Detect context.projectMetadata.hasRouter and send to the index" #1121

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Nov 12, 2024

Reverts #1112

Not all users have head installed. We will need to implement this manually I suppose.

📦 Published PR as canary version: 11.18.2--canary.1121.11796003673.0

✨ Test out this PR locally via:

npm install chromatic@11.18.2--canary.1121.11796003673.0
# or 
yarn add chromatic@11.18.2--canary.1121.11796003673.0

@tmeasday tmeasday added bug Classification: Something isn't working release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels Nov 12, 2024
Copy link

linear bot commented Nov 12, 2024

Copy link
Contributor

📦 Package Size: 5408 KB

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 8fe59b41 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8fe59b4) Report Missing Report Missing Report Missing
Head commit (951c0b2) 7138 4861 68.10%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1121) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@tmeasday tmeasday merged commit 582c044 into main Nov 12, 2024
24 of 26 checks passed
@tmeasday tmeasday deleted the revert-1112-tom/cap-2327-track-hasrouter-and-haspagecomponents-on-build-events branch November 12, 2024 11:05
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.18.1 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants