Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ggplot and tidyverse other code improvements #1

Open
wants to merge 149 commits into
base: master
Choose a base branch
from

Conversation

byandell
Copy link

@byandell byandell commented Apr 6, 2018

Dan,
I have pulled your recent commits to intermediate, and have two extra commits of my own. You can the mediation_scan and ggplot_mediation_scan in particular, and some changes to other routines to make them more general. I will be adding my mediation_test and mediation_triad in coming weeks.
Brian

@byandell
Copy link
Author

byandell commented Apr 8, 2018

I made some more additions to add mediation_test and mediation_triad. I have improvements I want to make on mediation_triad, to use model fit, but it is a decent first attempt. Note that the Tmem68 example that was in library has the target (Tmem68) among the mediators, so one must be careful.

@byandell
Copy link
Author

byandell commented Apr 9, 2018

Dan,
Your change in mediation.scan (and elsewhere) from POS to MIDDLE_POINT broke the example for mediation.scan. It would be better to leave as POS for generality and change your code something like the following:
med <- intermediate::mediation.scan(
target = pheno_clin[,pname,drop=FALSE],
mediator = expr_med,
annotation = annot.mrna.chr11 %>% rename(pos = "middle_point"),
covar = covar,
qtl.geno = ap,
method = "double-lod-diff")

…test; add summary method to mediation_triad; fix colors in mediation_effect; fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants