action: Add an option to run cilium-cli inside a container #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
force-pushed
the
pr/michi/i-like-aks
branch
from
95e015e
to
d57961a
Compare
michi-covalent
force-pushed
the
pr/michi/i-like-aks
branch
from
d57961a
to
4e0f4b5
Compare
Add image-repo and image-tag parameters to the cilium-cli action that set up cilium-cli to run inside a container. Update aks-byocni.yaml to run cilium-cli inside a container using the action instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/i-like-aks
branch
from
4e0f4b5
to
c48b06b
Compare
michi-covalent
changed the title
nbusseneau
approved these changes
Jun 25, 2024
asauber
approved these changes
Jun 25, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update gke.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.
Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Update docker run command to specify --user flag so that install-external-workload.sh gets created with correct permissions. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.
Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.
Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 25, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.
Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update gke.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update externalworklads.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.
Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
added a commit
that referenced
this pull request
Jun 26, 2024
Update multicluster.yaml to run cilium-cli inside a container instead of using cilium-cli-test-job-chart. Ref: #2623 Ref: #2627 Ref: cilium/design-cfps#9 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add image-repo and image-tag parameters to the cilium-cli action that set up cilium-cli to run inside a container. Update aks-byocni.yaml to run cilium-cli inside a container using the action instead of using cilium-cli-test-job-chart.
Ref: #2623
Ref: cilium/design-cfps#9