New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: run cilium-cli inside docker instead of using cilium-cli-test-job-chart helm chart #2623

Closed

michi-covalent opened this issue Jun 23, 2024 · 0 comments · Fixed by #2641

Assignees

Contributor

michi-covalent commented Jun 23, 2024

a minor quality of life improvement to make it easier to use cilium-cli in github workflows.

michi-covalent self-assigned this

michi-covalent added a commit that referenced this issue


          Dockerfile: Install aws / azure / gcloud CLIs

Install cloud CLIs so that you can run cilium-cli from inside a
container and connect to AKS / EKS / GKE clusters.

This commit also changes in-cluster scripts to use bash instead of sh.
Some of these scripts are not POSIX-compliant, and they don't work with
sh that comes with Ubuntu.

Ref: #2623
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

Dockerfile: Install aws / azure / gcloud CLIs #2624

Merged

michi-covalent added a commit that referenced this issue


          Dockerfile: Install aws / azure / gcloud CLIs

90ddea3

Install cloud CLIs so that you can run cilium-cli from inside a
container and connect to AKS / EKS / GKE clusters.

This commit also changes in-cluster scripts to use bash instead of sh.
Some of these scripts are not POSIX-compliant, and they don't work with
sh that comes with Ubuntu.

Ref: #2623
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          Dockerfile: Install aws / azure / gcloud CLIs

ce00e4e

Install cloud CLIs so that you can run cilium-cli from inside a
container and connect to AKS / EKS / GKE clusters.

This commit also changes in-cluster scripts to use bash instead of sh.
Some of these scripts are not POSIX-compliant, and they don't work with
sh that comes with Ubuntu.

Ref: #2623
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          action: Add an option to run cilium-cli inside a container

c48b06b

Add image-repo and image-tag parameters to the cilium-cli action that
set up cilium-cli to run inside a container. Update aks-byocni.yaml to
run cilium-cli inside a container using the action instead of using
cilium-cli-test-job-chart.

Ref: #2623
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

action: Add an option to run cilium-cli inside a container #2627

Merged

michi-covalent added a commit that referenced this issue


          action: Add an option to run cilium-cli inside a container

Add image-repo and image-tag parameters to the cilium-cli action that
set up cilium-cli to run inside a container. Update aks-byocni.yaml to
run cilium-cli inside a container using the action instead of using
cilium-cli-test-job-chart.

Ref: #2623
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          gke: Run cilium-cli inside a container

93fd5c0

Update gke.yaml to run cilium-cli inside a container instead of using
cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

gke: Run cilium-cli inside a container #2629

Merged

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

9b9c39e

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

external-workloads: Run cilium-cli inside a container #2630

Merged

michi-covalent added a commit that referenced this issue


          eks: Run cilium-cli inside a container

1326dd8

Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

eks: Run cilium-cli inside a container #2631

Merged

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

acc0959

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

0572f3d

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

multicluster: Run cilium-cli inside a container #2632

Merged

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

2e7f6ab

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart. Update docker run command to
specify --user flag so that install-external-workload.sh gets created
with correct permissions.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

558573e

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

f3f36d8

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

0f1ccde

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          eks: Run cilium-cli inside a container

9db68d5

Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

6d472dd

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          eks: Run cilium-cli inside a container

aa1d8bc

Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          eks: Run cilium-cli inside a container

ce91f76

Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          gke: Run cilium-cli inside a container

9e1942d

Update gke.yaml to run cilium-cli inside a container instead of using
cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          external-workloads: Run cilium-cli inside a container

6f3cca0

Update externalworklads.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

441e542

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          eks: Run cilium-cli inside a container

5146f46

Update {eks,eks-tunnel}.yaml to run cilium-cli inside a container
instead of using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

b3c9898

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          multicluster: Run cilium-cli inside a container

f2fba32

Update multicluster.yaml to run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Ref: #2623
Ref: #2627
Ref: cilium/design-cfps#9

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent added a commit that referenced this issue


          Remove cilium-cli-test-job-chart

6f9e6ee

Now all the cloud workflows run cilium-cli inside a container instead of
using cilium-cli-test-job-chart.

Also update eks-tunnel.yaml and remove the helm install step. I forgot
to remove it in 5146f46.

Fixes: #2623

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>

michi-covalent mentioned this issue

Remove cilium-cli-test-job-chart #2641

Merged

michi-covalent closed this as completed in #2641

michi-covalent closed this as completed in

4dc7648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment