Remove wrong key lookup for service name in k8s labels #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannikmesserli
force-pushed
the
pr/yannik/792-service-name
branch
from
a7433df
to
3fe1830
Compare
geakstr
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #792.
Description
This PR fixes a bug introduced in https://github.com/isovalent/hubble-ui-enterprise/pull/1108: the key
componentwas wrongly added to the list of keys to retrieve an app app name from k8s labels.Changes
componentScreenshots
Unit tests
None added.
Functional tests
componentis suffixing it:kubectl label pods crawler-7748bbc7b8-xr2vn app.kubernetes.io/component=api -n tenant-jobscomponentlabel