Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Continuation of #1930, this time fix the download button.
Cinny uses
file-saver
to implment the download button, thefile-saver
implmentation has the following code:https://github.com/eligrey/FileSaver.js/blob/5bb701bd6ea05a02836daf8ef88ec350a1dd4d83/src/FileSaver.js#L96-L98
which checks CORS using the following code:
https://github.com/eligrey/FileSaver.js/blob/5bb701bd6ea05a02836daf8ef88ec350a1dd4d83/src/FileSaver.js#L47-L55
In the earlier implmentation,
HEAD
request wasn't hooked, so whenfile-saver
saves a file, it'll believe CORS request failed and try to open the URL in the browser tab, which won't work at all with authenicated media endpoints.By hooking
HEAD
requests too,file-saver
would properly save this file without opening a new tab.Type of change
Checklist: