Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tuning loader options #333

Merged
merged 19 commits into from
Nov 28, 2022
Merged

Allow tuning loader options #333

merged 19 commits into from
Nov 28, 2022

Conversation

lucaviolanti
Copy link
Contributor

This addresses #332.

SnakeYaml sets various default limits, and supports overriding these values via LoaderOptions.

This PR enables customisation of these limits, following a similar pattern as #205.

@zarthross
Copy link
Member

Thanks for the PR!

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2022

Codecov Report

Base: 87.30% // Head: 89.31% // Increases project coverage by +2.01% 🎉

Coverage data is based on head (8370cc8) compared to base (9df6d5c).
Patch coverage: 63.63% of modified lines in pull request are covered.

❗ Current head 8370cc8 differs from pull request most recent head 65bf5ef. Consider uploading reports for the commit 65bf5ef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
+ Coverage   87.30%   89.31%   +2.01%     
==========================================
  Files           5        5              
  Lines         126      131       +5     
  Branches        9        9              
==========================================
+ Hits          110      117       +7     
+ Misses         16       14       -2     
Impacted Files Coverage Δ
src/main/scala/io/circe/yaml/Parser.scala 87.50% <63.63%> (-1.60%) ⬇️
src/main/scala/io/circe/yaml/parser/package.scala 50.00% <0.00%> (+12.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zarthross
Copy link
Member

[error] circe-yaml: Failed binary compatibility check against io.circe:circe-yaml_3:0.14.2! Found 1 potential problems
[error]  * static method yamlToJson(org.yaml.snakeyaml.nodes.Node)scala.util.Either in class io.circe.yaml.Parser does not have a correspondent in current version
[error]    filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("io.circe.yaml.Parser.yamlToJson")
[error] stack trace is suppressed; run last mimaReportBinaryIssues for the full output
[error] (mimaReportBinaryIssues) Failed binary compatibility check against io.circe:circe-yaml_3:0.14.2! Found 1 potential problems
[error] Total time: 9 s, completed Nov 18, 2022 4:06:24 PM

@zarthross zarthross merged commit e273a7e into circe:main Nov 28, 2022
@lucaviolanti lucaviolanti deleted the allow-tuning-loader-options branch November 28, 2022 14:49
sideeffffect added a commit to sideeffffect/circe-yaml that referenced this pull request Dec 16, 2022
@sideeffffect sideeffffect mentioned this pull request Dec 16, 2022
jeffmay pushed a commit that referenced this pull request Jan 4, 2023
* Backport #333

#333

* fix comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants