Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Untracked] Add walletId & remove beneficiaryName to wire creation page #75

Merged
merged 1 commit into from
Sep 18, 2020
Merged

[Untracked] Add walletId & remove beneficiaryName to wire creation page #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/wiresApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { getAPIHostname } from './apiTarget'

export interface CreateWireAccountPayload {
idempotencyKey: string
beneficiaryName: string
walletId: string
accountNumber?: string
routingNumber?: string
iban?: string
Expand Down
6 changes: 3 additions & 3 deletions lib/wiresTestData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export const exampleWireAccounts = [
{
title: 'US Bank Account',
formData: {
beneficiaryName: 'Satoshi Nakamoto',
walletId: null as any,
MasterXen marked this conversation as resolved.
Show resolved Hide resolved
accountNumber: '11111111111',
routingNumber: '121000248',
iban: '',
Expand All @@ -29,7 +29,7 @@ export const exampleWireAccounts = [
{
title: 'German Bank Account',
formData: {
beneficiaryName: 'Satoshi Nakamoto',
walletId: null as any,
accountNumber: '',
routingNumber: '',
iban: 'DE31100400480532013000',
Expand All @@ -56,7 +56,7 @@ export const exampleWireAccounts = [
{
title: 'Mexican Bank Account',
formData: {
beneficiaryName: 'Satoshi Nakamoto',
walletId: null as any,
accountNumber: '002010077777777771',
routingNumber: 'BDEMMXMF',
iban: '',
Expand Down
12 changes: 7 additions & 5 deletions pages/debug/wires/create.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,10 @@

<v-form>
<v-text-field
v-model="formData.beneficiaryName"
label="Beneficiary Name"
v-model="formData.walletId"
label="Wallet Id"
:rules="[rules.isNumber, rules.required]"
hint="Unique identifier of the wallet that you wish to wire the funds to. "
/>

<v-text-field
Expand Down Expand Up @@ -173,7 +175,7 @@ import ErrorSheet from '@/components/ErrorSheet.vue'
export default class CreateCardClass extends Vue {
// data
formData = {
beneficiaryName: '',
walletId: '',
accountNumber: '',
routingNumber: '',
iban: '',
Expand Down Expand Up @@ -225,7 +227,7 @@ export default class CreateCardClass extends Vue {
async makeApiCall() {
this.loading = true
const {
beneficiaryName,
walletId,
accountNumber,
routingNumber,
iban,
Expand All @@ -235,7 +237,7 @@ export default class CreateCardClass extends Vue {

const payload: CreateWireAccountPayload = {
idempotencyKey: uuidv4(),
beneficiaryName,
walletId,
accountNumber,
routingNumber,
iban,
Expand Down