Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regroup and rename APIs in Sample App #94

Merged
merged 10 commits into from
Dec 9, 2020

Conversation

alandn-circle
Copy link
Contributor

@alandn-circle alandn-circle commented Dec 1, 2020

We want to regroup API endpoints based on which API(s) they belong to (Payments, Payouts, Digital Dollar Accounts, Marketplace). We also want to add a new section entitled "Core Functionality" that contains endpoints present in all APIs.

The bulk of these changes lie in the navigation and the API viewers for such APIs.

@alandn-circle
Copy link
Contributor Author

alandn-circle commented Dec 1, 2020

Once these changes are good to go, I'll also be removing the files debug/wallets/index.vue and debug/businessAccount/index.vue (these will be outdated) prior to merging to master.

MasterXen
MasterXen previously approved these changes Dec 8, 2020
Copy link
Contributor

@MasterXen MasterXen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally (including marketplaces) and compared to the ordering of the updated API docs

@kristinfritsch
Copy link
Contributor

Some cleanup comments, but not a blocker:

  • (Caution: When using a production api key it will charge your card) can be removed from /debug/payouts
  • let's remove the page /debug/ (it is linked from the home page and we should remove the link there too)
  • This sample web application demonstrates some of the features of the Circle Payments API let's change that to This sample web application demonstrates some of the features of the Circle APIs with link to https://www.circle.com/en/developers

@MasterXen MasterXen mentioned this pull request Dec 8, 2020
MasterXen
MasterXen previously approved these changes Dec 9, 2020
@MasterXen
Copy link
Contributor

Build failed due to:

/opt/circle/payments-sample-app/src/lib/businessAccount/depositsApi.ts
--
382 | 38:1  error  Delete `⏎`                          prettier/prettier
383 | 38:1  error  More than 1 blank line not allowed  no-multiple-empty-lines

Prettier is not playing games!

@MasterXen
Copy link
Contributor

I "fixed" the extra line break violation

@MasterXen MasterXen merged commit 627e89c into circlefin:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants