Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ACH payment #95

Merged
merged 4 commits into from
Dec 8, 2020
Merged

Conversation

mcinar-circle
Copy link
Contributor

Duplicate of #88, merge conflicts resolved.

this.formData.verification = 'cvv'
}
if (val === 'ach') {
this.formData.verification = 'none'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of setting verification to none does it make more sense to set it to null or undefined so it's not send in the payment request?

@MasterXen
Copy link
Contributor

@mcinar-circle Heads-up that #94 changes some of the payment pages so this may need to be updated once the API repositioning goes live tomorrow.

@jcantwell jcantwell merged commit 03c187c into circlefin:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants