upgrade master minter contracts to v.0.6.12, merge multi-issuer branch to master #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MINT prototype
All tests use global Accounts object from AccountUtils.
Increase code coverage
Changed MintController MintableTokenInterface token to MinterManagementInterface minterManager
Add removeController() function
Fix build failure circlefin#214
…kMINTp0 function for unit tests
* add ControllerState object to ControllerTestUtils.js * checkVariables takes as input either FiatTokenV1 or MintController * replaced literal objects with actual objects * Using library funciton clone(), removing logObject, and creating checkMINTp0 function for unit tests * removed unused clone code * Updated yarn.lock and package.json to use yarn 1.10.1
Switch to CSV file verification
* Wrote 15 BasicTests * Finish writing BasicTests, added ABITests * Removed unused variables, fixed comments, and deleted quotation marks from csv file * returning quatation marks
Enable syntax highlighting
walkerq
changed the title
walkerq
commented
May 28, 2021
|
@walkerq is this ready for review? |
@mboorstin-circle almost, but there's still some cruft I'd like to cleanup, can post for review tomorrow |
No rush, just wanted to make sure I wasn't blocking it. Thanks! |
walkerq
commented
Jun 1, 2021
walkerq
force-pushed
the
multi-issuer-upgrade-to-sol-0.6
branch
from
29d0f54 to
89bf348
Compare
eztierney
reviewed
Jun 1, 2021
eztierney
requested changes
Jun 1, 2021
walkerq
commented
Jun 2, 2021
eztierney
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Testing:
Incorporates tests originally written on the multi-issuer branch. Since there has been significant test restructuring since these tests were originally written, there was a bit of refactoring, linting, etc. needed in order to get those tests running in the current test suite on master.