Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ScubaGear PowerShell module dependency versions #1100

Merged
merged 1 commit into from
May 20, 2024

Conversation

buidav
Copy link
Collaborator

@buidav buidav commented May 16, 2024

🗣 Description

Manually bump current dependencies until the automated PS version bump workflow in #1096 is complete

Did all the needed dependency pull requests into 1 PR.
Much easier to do this in 1 branch rather than 3 separate ones as juggling different versions for 3 modules became complex.

  • Bump max dependency version for Microsoft Teams PowerShell to <= 6.99.99999 (Last possible Major version)
  • Bump max dependency version for SharePoint PowerShell to <= 16.0.24810.12000 (Latest version) (Pin)
  • Bump max dependency version for MS Graph PowerShell from to <= 2.19.99999 (Latest version) (Pin)

💭 Motivation and context

Closes #998
Closes #999

🧪 Testing

  • For a client that has used ScubaGear before in the utils folder run UninstallModules.ps1 until no more stray PowerShell modules exist on the client.
  • Use Get-InstalledModule to see if the client still has stray dependencies.
  • Import-Module .\PowerShell\ScubaGear to import then run Initialize-SCuBA to install the new depedencies.
  • Run Invoke-SCuBA with teams, aad, sharepoint ProductNames parameters separately to see if there are issues.
  • sharepoint MUST be run interactively.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • PR targets the correct parent branch (e.g., main or release-name) for merge.
  • Changes are limited to a single goal - eschew scope creep!
  • Changes are sized such that they do not touch excessive number of files.
  • All future TODOs are captured in issues, which are referenced in code comments.
  • These code changes follow the ScubaGear content style guide.
  • Related issues these changes resolve are linked preferably via closing keywords.
  • All relevant type-of-change labels added.
  • All relevant project fields are set.
  • All relevant repo and/or project documentation updated to reflect these changes.
  • Unit tests added/updated to cover PowerShell and Rego changes.
  • All relevant functional tests passed.
  • All automated checks (e.g., linting, static analysis, unit/smoke tests) passed.

✅ Pre-merge checklist

  • PR passed smoke test check.

  • Feature branch has been rebased against changes from parent branch, as needed

    Use Rebase branch button below or use this reference to rebase from the command line.

  • Resolved all merge conflicts on branch

  • Notified merge coordinator that PR is ready for merge via comment mention

✅ Post-merge checklist

  • Feature branch deleted after merge to clean up repository.
  • Verified that all checks pass on parent branch (e.g., main or release-name) after merge.

@buidav buidav added enhancement This issue or pull request will add new or improve existing functionality upstream update This issue or pull request pulls in upstream updates labels May 16, 2024
@buidav buidav added this to the Halibut milestone May 16, 2024
@buidav buidav self-assigned this May 16, 2024
@buidav buidav changed the title bump dependencies Bump ScubaGear PowerShell module dependency versions May 16, 2024
Copy link
Collaborator

@nanda-katikaneni nanda-katikaneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did suggested testing on my vm - works fine. Approved.

@buidav
Copy link
Collaborator Author

buidav commented May 17, 2024

@nanda-katikaneni ready to merge

@nanda-katikaneni nanda-katikaneni merged commit 943c003 into main May 20, 2024
15 checks passed
@nanda-katikaneni nanda-katikaneni deleted the psdependency-updates-5-2024 branch May 20, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue or pull request will add new or improve existing functionality upstream update This issue or pull request pulls in upstream updates
Projects
None yet
3 participants