Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputTime dropdown scrolling #249

Closed
pixelbandito opened this issue Jul 30, 2020 · 0 comments · Fixed by #252
Closed

InputTime dropdown scrolling #249

pixelbandito opened this issue Jul 30, 2020 · 0 comments · Fixed by #252
Assignees
@pixelbandito
Labels
new feature Will require a minor version bump

Comments

@pixelbandito
Copy link
Contributor

pixelbandito commented Jul 30, 2020 •
edited
Loading

Relates to #203

  • dropdown has a max-height and internal scrolling
@pixelbandito pixelbandito self-assigned this Jul 30, 2020
@pixelbandito pixelbandito added the new feature Will require a minor version bump label Jul 30, 2020
pixelbandito added a commit that referenced this issue Aug 3, 2020
@pixelbandito
feat: InputTime dropdown menu has default max height of 10.5 rows
3724fa0 
fixes #249
@pixelbandito pixelbandito changed the title InputTime dropdown scrolling and navigation improvements InputTime dropdown scrolling Aug 3, 2020
@pixelbandito pixelbandito mentioned this issue Aug 3, 2020
Merged
pixelbandito added a commit that referenced this issue Aug 3, 2020
@pixelbandito
feat: InputTime dropdown menu has default max height of 10.5 rows (#252)
719ad61 
* feat: InputTime dropdown menu has default max height of 10.5 rows
fixes #249

* docs: Add InputTime stories for disabled and sans-validation cases

* feat: InputTime has dropdownProps for customizing display of dropdown menu

* refactor: InputTime Dropdown CSS refactor with clear variable names.
NicolasBiehler pushed a commit to NicolasBiehler/rover-ui that referenced this issue Aug 12, 2020
@pixelbandito @NicolasBiehler
feat: InputTime dropdown menu has default max height of 10.5 rows (ci…
4466e87 
…sion#252)

* feat: InputTime dropdown menu has default max height of 10.5 rows
fixes cision#249

* docs: Add InputTime stories for disabled and sans-validation cases

* feat: InputTime has dropdownProps for customizing display of dropdown menu

* refactor: InputTime Dropdown CSS refactor with clear variable names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelbandito pixelbandito

Labels
new feature Will require a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: InputTime dropdown menu has default max height of 10.5 rows cision/rover-ui
1 participant
@pixelbandito