feat: InputTime dropdown menu has default max height of 10.5 rows #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkordik
reviewed
Aug 3, 2020
dkordik
reviewed
Aug 3, 2020
nvmusoke
approved these changes
Aug 3, 2020
dkordik
approved these changes
Aug 3, 2020
bkonuwa
approved these changes
Aug 3, 2020
NicolasBiehler
pushed a commit
to NicolasBiehler/rover-ui
that referenced
this pull request
Aug 12, 2020
…sion#252) * feat: InputTime dropdown menu has default max height of 10.5 rows fixes cision#249 * docs: Add InputTime stories for disabled and sans-validation cases * feat: InputTime has dropdownProps for customizing display of dropdown menu * refactor: InputTime Dropdown CSS refactor with clear variable names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #249
Feature:
menuPropstoEasyDropdown.InputTimetakesdropdownPropswhich are passed toInputTime/Dropdown.InputTime/Dropdownpasses anymenuProps,toggleProps, or top-levelpassedPropsdown to its children in the appropriate slots.InputTime/Dropdownadds a CSS class to the internalDropdown.Menuwhich limits the height to 5.5 rows.Dropdown.Menuhas a default style ofoverflow-y: autofor scrolling.Docs:
Fix:
InputTime's clock icon to use correct color when disabled.InputTime'sfauxDisabledprop to pass it down to the correct child, so that class has the desired visual effect.