dev/core/1412 CiviMail sent via wp-cli and cron mangles mailing urls… #15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I'm giving this MOP as @kcristiano is the reviewer in this case of a patch by @christianwach |
|
Jenkins re test this please |
|
For some test coverage, see #15922 |
|
We need a 5.19 PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on WP
Patch created by @christianwach
https://lab.civicrm.org/dev/core/issues/1412
Overview
Starting in 5.19 we have an issue with URLs in CiviMail. If Track links is on the URLs get mangled. Dradt Emails are fine, as well as if you kick off the scheduled job manually (UI or CLI).
However, if cron runs the job the URLS are broken:
Mailing Urls expected:
https://example.org//wp-content/plugins/civicrm/civicrm/extern/url.php?u=19&qid=31
But we get:
https://example.org/home/example/public_html/wp-content/plugins/civicrm/civicrm/extern/url.php?u=19&qid=31
Before
Mangled URLs
After
Proper URls