Reinstate traversal as "method of last resort" to find WordPress #15929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follows on from #15919 to reinstate directory traversal as "method of last resort" to find WordPress location. Although the code in the previous commit should work most of the time, I'm reluctant to see the fallback code removed at this stage, even though there are issues with it.
Before
Fallback code removed.
After
Fallback code reinstated. I have rejigged the method so that the flow of logic is clearer.
Comments
Ultimately it would be good to be able to remove the fallback code, but I would like it to remain until all the directory traversal code can be conclusively and comprehensively removed.