Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate traversal as "method of last resort" to find WordPress #15929

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

christianwach
Copy link
Member

@christianwach christianwach commented Nov 22, 2019

Overview

Follows on from #15919 to reinstate directory traversal as "method of last resort" to find WordPress location. Although the code in the previous commit should work most of the time, I'm reluctant to see the fallback code removed at this stage, even though there are issues with it.

Before

Fallback code removed.

After

Fallback code reinstated. I have rejigged the method so that the flow of logic is clearer.

Comments

Ultimately it would be good to be able to remove the fallback code, but I would like it to remain until all the directory traversal code can be conclusively and comprehensively removed.

@civibot
Copy link

civibot bot commented Nov 22, 2019

(Standard links)

@civibot civibot bot added the 5.20 label Nov 22, 2019
@seamuslee001
Copy link
Contributor

I'm going to add merge on pass to this, makes sense to me

@christianwach
Copy link
Member Author

@seamuslee001 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants