SearchKit - Support all fields as tokens #20880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
force-pushed
the
searchKitTokenSelect
branch
from
7cfc696
to
2c49408
Compare
colemanw
force-pushed
the
searchKitTokenSelect
branch
from
2c49408
to
6e2d7f8
Compare
…idge Symmetric bridge entities such as RelationshipCache which joins Contact to Contact need to have the second entity id availble to join on.
Previously, only fields present in the SELECT clause could be tokens. Now the SearchDisplay::Run api will add any fields used as tokens to the SELECT automatically.
colemanw
force-pushed
the
searchKitTokenSelect
branch
from
6e2d7f8
to
791f677
Compare
|
retest this please |
|
This seems to work for me on the PR test site and it has passed the unit tests. Merging |
|
This seems to work for me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves SearchDisplay support for tokens (in link URLs, list labels, and rewritten fields).
Before
Only fields present in the SELECT clause could be tokens. And the selector didn't do a good job of differentiating the fields of multiple entities e.g. a search for Contact with Related Contacts would look like this:
After
Any field can be used as a token.
The
SearchDisplay::RunAPI will add any fields used as tokens to the SELECT automatically.Comments
The new token selector depends on #20879 (merged).