Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Add links to view/edit/delete relationships #20886

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jul 17, 2021

Overview

Adds links to view/edit/delete the relationship when joining on related contacts.

Before

Links available to view/edit/delete the related contact, but not the relationship itself.

After

image

Comments

The phrasing of the link labels is cumbersome, I know, but it had to be a) clear which base contact (there could be many) and which relationship (ditto), and b) metadata-based and c) translatable.

To fully function, this PR depends on #20883 and #20880

@civibot civibot bot added the master label Jul 17, 2021
@civibot
Copy link

civibot bot commented Jul 17, 2021

(Standard links)

@Anatoleallain
Copy link

The links are working :) but I think the direction of the relation is supposed to be the other way
if I'm on contact A I should see the relation A to B and not B to A
image
image

@eileenmcnaughton
Copy link
Contributor

@colemanw - please self-merge this upon approval by @Anatoleallain - the code looks sensible

@colemanw
Copy link
Member Author

Ok. This PR doesn't have anything to do with relationship direction - it just presents whatever's in the metadata. So I'll merge this & fix the metadata/form in a different PR. I think it's related to #20883

@colemanw colemanw merged commit 11b0c2b into civicrm:master Jul 20, 2021
@colemanw colemanw deleted the searchKitRelationshipLinks branch July 20, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants