(E2E) testErrorChrome - Skip Backdrop and D8+ (much like D7) #23398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
This test was added during 5.50.alpha (civicrm#23257, civicrm#22805). It's purpose is to assert that the page-chrome/site-wide-template is present on certain error-messages; however, the underlying behavior was only implemented on WordPress. It has not yet been implemented on other CMS. Before ------ * __WordPress__: Runs testErrorChrome. Expected to pass. * __Drupal 7__: Skip testErrorChrome (mostly) because it is expected to fail. * __Drupal 8+, Backdrop__: Runs testErrorChrome. Fails. After ----- * __WordPress__: Runs testErrorChrome. Expected to pass. * ___Drupal 7, Drupal 8+, Backdrop__: Skip testErrorChrome (mostly) because it is expected to fail. Comment ------- It still runs `testErrorChrome` for `permission` errors; per MM discussion, it appears that this does actually work, but we need to tune assertion for BD+D8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This test was added during 5.50.alpha (#23257, #22805). It's purpose is to
assert that the page-chrome/site-wide-template is present on certain
error-messages; however, the underlying behavior was only implemented on
WordPress. It has not yet been implemented on other CMS.
Before
After
Comment
It still runs
testErrorChromeforpermissionerrors; per MM discussion, it appears that this does actually work, but we need another patch to tune assertion for BD+D8.