Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(E2E) testErrorChrome - Skip Backdrop and D8+ (much like D7) #23398

Merged
merged 1 commit into from
May 7, 2022
Merged

(E2E) testErrorChrome - Skip Backdrop and D8+ (much like D7) #23398

merged 1 commit into from
May 7, 2022

Commits on May 6, 2022

  1. (E2E) testErrorChrome - Skip Backdrop and D8+ (much like D7) 

    This test was added during 5.50.alpha (civicrm#23257, civicrm#22805).  It's purpose is to
assert that the page-chrome/site-wide-template is present on certain
error-messages; however, the underlying behavior was only implemented on
WordPress. It has not yet been implemented on other CMS.

Before
------

* __WordPress__: Runs testErrorChrome. Expected to pass.
* __Drupal 7__: Skip testErrorChrome (mostly) because it is expected to fail.
* __Drupal 8+, Backdrop__: Runs testErrorChrome. Fails.

After
-----

* __WordPress__: Runs testErrorChrome. Expected to pass.
* ___Drupal 7, Drupal 8+, Backdrop__: Skip testErrorChrome (mostly) because it is expected to fail.

Comment
-------

It still runs `testErrorChrome` for `permission` errors; per MM discussion, it appears that this does actually work, but we need
to tune assertion for BD+D8.
    @totten
    totten committed May 6, 2022
    Configuration menu
    Copy the full SHA
    af71951 View commit details
    Browse the repository at this point in the history