Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instant accessor for InfExtendedTime type #18

Merged
merged 3 commits into from
Jun 18, 2020

Conversation

fchorney
Copy link
Contributor

@fchorney fchorney commented Jun 16, 2020

Added a get_property accessor for instant, as well as some arithmetic +/- for dealing with Infinity.

Closes #17

This PR is based on #15, and thus has all the changes from that PR integrated into this one. #15 needs to be merged in before this PR.

@cjdoris cjdoris merged commit d07e19c into cjdoris:master Jun 18, 2020
@cjdoris
Copy link
Owner

cjdoris commented Jun 18, 2020

Thanks, though a better solution would be to return a InfExtendedInstant but that doesn't exist yet (#14). So in the future the return type of this accessor might change.

@fchorney
Copy link
Contributor Author

Fair enough, I didn't think to add that. Definitely a possibility for a future change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't access instant for InfExtendedTime type
2 participants