Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests using Infinity.jl #107

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Add tests using Infinity.jl #107

merged 5 commits into from
Aug 13, 2020

Conversation

fchorney
Copy link
Member

Depends on cjdoris/Infinity.jl#16 and cjdoris/Infinity.jl#18 to be merged in.

This adds tests using Infinity.jl to confirm that it works with intervals.

@fchorney fchorney requested a review from omus as a code owner June 16, 2020 19:18
@fchorney fchorney force-pushed the fc/infinity-jl-tests branch 2 times, most recently from 5b38559 to 4a95e07 Compare June 19, 2020 18:45
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #107 into master will decrease coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   74.39%   74.23%   -0.17%     
==========================================
  Files          10       10              
  Lines         457      458       +1     
==========================================
  Hits          340      340              
- Misses        117      118       +1     
Impacted Files Coverage Δ
src/anchoredinterval.jl 96.15% <100.00%> (+0.04%) ⬆️
src/interval.jl 94.57% <0.00%> (-0.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aeb592...93b79df. Read the comment docs.

Copy link
Collaborator

@omus omus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Let's hold off on merging until #104 is in and we'll go from there. Thanks for this :)

@omus
Copy link
Collaborator

omus commented Jun 26, 2020

I'll merge this today. I kind of want to tag it as a feature but since it only effects tests I could do it as a bugfix.

@omus
Copy link
Collaborator

omus commented Jul 28, 2020

Sorry this totally fell off my radar. I believe we may need some tests for AnchoredIntervals but I'll investigate that and push the necessary changes.

@omus
Copy link
Collaborator

omus commented Jul 28, 2020

During the course of completing this PR I noticed some additional work to be done to Infinity.jl:

@omus
Copy link
Collaborator

omus commented Jul 29, 2020

The CI failures were hard to track down but it ended up being an issue in Infinity.jl: cjdoris/Infinity.jl#23. The issue has a fix cjdoris/Infinity.jl#24 but we'll require that fix to be merged and tagged before we can merge this change.

@omus
Copy link
Collaborator

omus commented Aug 11, 2020

Looks like we also need: cjdoris/Infinity.jl#30

@omus
Copy link
Collaborator

omus commented Aug 12, 2020

Finally going to be able to wrap this one up.

@omus omus merged commit d7a27c3 into master Aug 13, 2020
@omus omus deleted the fc/infinity-jl-tests branch August 13, 2020 03:58
@omus omus mentioned this pull request Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants