fix!: allow URIs without authority component #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, links were naively required to be provided as a so-called
protocol
andlink
pair, whereprotocol
was ascheme
andlink
referred theauthority
andpath
. The purpose of this format was to provide a simple way to display urls without thescheme
, while including the scheme inhref
s by constructing them with{{protocol}}://{{link}}
.This made the implicit assumption that all URIs had an authority component, which was shown to be untrue by the presence of a
mailto
link, which would incorrectly have a//
placed between thescheme
(mailto) and thepath
(cjshearer@live.com).This commit changes the format expected for urls provided in
resume.yaml
back to a single string. Where thescheme
is not desired for display, the builtin URL parsing is used to assist removing it.resolves #19