Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: allow URIs without authority component #22

Merged
merged 1 commit into from
Oct 30, 2023

Commits on Oct 30, 2023

  1. fix!: allow URIs without authority component

    Previously, links were naively required to be provided as a so-called
    `protocol` and `link` pair, where `protocol` was a `scheme` and `link`
    referred the `authority` and `path`. The purpose of this format was to
    provide a simple way to display urls without the `scheme`, while
    including the scheme in `href`s by constructing them with
    `{{protocol}}://{{link}}`.
    
    This made the implicit assumption that all URIs had an authority
    component, which was shown to be untrue by the presence of a `mailto`
    link, which would incorrectly have a `//` placed between the `scheme`
    (mailto) and the `path` (cjshearer@live.com).
    
    This commit changes the format expected for urls provided in
    `resume.yaml` back to a single string. Where the `scheme` is not desired
    for display, the builtin URL parsing is used to assist removing it.
    
    resolves #19
    cjshearer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    79ee153 View commit details
    Browse the repository at this point in the history