Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Introduced EditorUI#update event #131

Merged
merged 12 commits into from
Jun 29, 2018
Merged

Introduced EditorUI#update event #131

merged 12 commits into from
Jun 29, 2018

Conversation

@oleq oleq requested a review from Mgsy June 27, 2018 15:04
@oleq
Copy link
Member

oleq commented Jun 27, 2018

@Mgsy Can you check out the constellation? The changes affect almost every feature and there could be serious regressions.

@Mgsy

This comment has been minimized.

@Mgsy

This comment has been minimized.

@Mgsy

This comment has been minimized.

@Mgsy

This comment has been minimized.

@oskarwrobel

This comment has been minimized.

@Mgsy
Copy link
Member

Mgsy commented Jun 28, 2018

The link balloon 'jumps' after applying the link:

bug_cke5

After changing throttling time from 50ms to 10ms in this line, everything works fine.

@oskarwrobel
Copy link
Contributor Author

The link balloon 'jumps' after applying the link:

Done.

@coveralls
Copy link

coveralls commented Jun 28, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 051d76b on t/130 into 7dda00a on master.

Copy link
Member

@Mgsy Mgsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@oleq oleq merged commit 734166a into master Jun 29, 2018
@oleq oleq deleted the t/130 branch June 29, 2018 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce EditorUI#update event
4 participants