This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Used EditorUI as a BalloonEditorUI parent class. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
suggested changes
Jun 27, 2018
tests/ballooneditorui.js
Outdated
| @@ -134,8 +125,8 @@ describe( 'BalloonEditorUI', () => { | |||
| } ); | |||
|
|
|||
| describe( 'destroy()', () => { | |||
| it( 'destroys the #view', () => { | |||
| const spy = sinon.spy( view, 'destroy' ); | |||
| it( 'calls EditorUI#destroy', () => { | |||
There was a problem hiding this comment.
Since we're sure this is an instance of EditorUI and there's no custom destroy() implementation, checking that any longer makes sense IMO.
There was a problem hiding this comment.
Fixed here and in the all related PR's.
bhayward93
pushed a commit
to bhayward93/ckeditor5-editor-balloon
that referenced
this pull request
Feb 27, 2020
Internal: Introduced ESLint and Travis. See ckeditor/ckeditor5#1236.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal: Used EditorUI as a BalloonEditorUI parent class.
Part of