Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating peerDependencies and support dry-run for release tool #420

Merged
merged 10 commits into from
Jul 17, 2018

Conversation

pomek
Copy link
Member

@pomek pomek commented Jul 9, 2018

Suggested merge commit message (convention)

Feature: The release tool supports updating the peerDependencies in package.json. Introduced a dryRun mode which allows testing the whole release process without publishing anything. The changelog generator for sub-repositories accepts the newVersion parameter. All generated changelog will use the version instead of analyzing a history of commits in a given repository. See ckeditor/ckeditor5#1061.

Dry run mode for release sub-repositories:

  • npm version will not create a tag (only the commit will be made),
  • npm pack will be called instead of npm publish (it packs the whole release to a ZIP archive),
  • git push will be replaced with a log on the screen,
  • creating a release on GitHub will be replaced with a log that will contain a URL to the release,
  • every called command will be displayed.

@@ -196,7 +221,8 @@ module.exports = function releaseSubRepositories( options ) {
const releaseDetails = packagesToRelease.get( packageJson.name );
const errorsForPackage = validatePackageToRelease( {
changes: releaseDetails.changes,
version: releaseDetails.version
version: releaseDetails.version,
allowOtherBranch: dryRun === true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@coveralls
Copy link

coveralls commented Jul 16, 2018

Coverage Status

Coverage increased (+0.1%) to 90.331% when pulling 7d880bc on t/ckeditor5/1061 into 7ffe0b9 on master.

@Reinmar Reinmar merged commit 263f37b into master Jul 17, 2018
@Reinmar Reinmar deleted the t/ckeditor5/1061 branch July 17, 2018 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants