-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating peerDependencies and support dry-run for release tool #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for updating peerDependencies.
This was referenced Jul 9, 2018
Reinmar
reviewed
Jul 16, 2018
@@ -196,7 +221,8 @@ module.exports = function releaseSubRepositories( options ) { | |||
const releaseDetails = packagesToRelease.get( packageJson.name ); | |||
const errorsForPackage = validatePackageToRelease( { | |||
changes: releaseDetails.changes, | |||
version: releaseDetails.version | |||
version: releaseDetails.version, | |||
allowOtherBranch: dryRun === true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
…into t/ckeditor5/1061
…ckeditor5 with a slight delay, don't run all CIs automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: The release tool supports updating the
peerDependencies
inpackage.json
. Introduced adryRun
mode which allows testing the whole release process without publishing anything. The changelog generator for sub-repositories accepts thenewVersion
parameter. All generated changelog will use the version instead of analyzing a history of commits in a given repository. See ckeditor/ckeditor5#1061.Dry run mode for release sub-repositories:
npm version
will not create a tag (only the commit will be made),npm pack
will be called instead ofnpm publish
(it packs the whole release to a ZIP archive),git push
will be replaced with a log on the screen,