Improved the release scripts #1143
Conversation
| @@ -20,7 +20,7 @@ then | |||
| mgit exec 'git checkout -b stable 2> /dev/null && git push origin stable && git checkout master' | |||
|
|
|||
| # Update all `stable` branches in all packages. | |||
| mgit exec 'git checkout stable && git merge master && git checkout master' | |||
| mgit exec 'git checkout stable && git pull origin stable && git merge master && git checkout master' | |||
There was a problem hiding this comment.
We need to pull the stable branch because it could be behind to the remote.
scripts/release/changelog.js
Outdated
| const devEnv = require( '@ckeditor/ckeditor5-dev-env' ); | ||
| const commonOptions = { | ||
| cwd: process.cwd(), | ||
| packages: 'packages' | ||
| packages: 'packages', | ||
| newVersion: process.argv[ 2 ] || null |
There was a problem hiding this comment.
New version of what? Does this option make sense in CKEditor 5?
There was a problem hiding this comment.
For the real release - nope. But for testing (like I often do) - yes.
We can skip that and I'll modify this file when I'll need that.
There was a problem hiding this comment.
newVersion for changelog of course. It's a version that you need to specify based on history of commits.
There was a problem hiding this comment.
newVersion for changelog of course. It's a version that you need to specify based on history of commits.
For which changelog? This task builds 30x changelogs. Does it affect all pkgs?
There was a problem hiding this comment.
Anyway, I just want to have a clarity here. You're adding an option so you should be clear why. If it's an option for tests, then please add a comment clarifying this in the code.
There was a problem hiding this comment.
That was my goal. It speeds up testing this tool. I don't lose time for parsing commits from repositories and pasting the same version as an answer for the question "type new version".
There was a problem hiding this comment.
It could even be quite useful for me in the future, once I'd have to release for e.g. the next major version of every package because of something. Then, we could make this option to also accept values such as major or next-alpha. But that's for the future, of course.
There was a problem hiding this comment.
Reported as a new issue: https://github.com/ckeditor/ckeditor5-dev/issues/421
Suggested merge commit message (convention)
Internal: Added support for generating the changelog for all packages with the same version. The script for releasing packages support
dry-runmode now. See #1061.Requires: ckeditor/ckeditor5-dev#420