Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7962: Implemented the toggle button for the manual tests sidebar #666

Merged
merged 1 commit into from
Aug 31, 2020
Merged

#7962: Implemented the toggle button for the manual tests sidebar #666

merged 1 commit into from
Aug 31, 2020

Conversation

oleq
Copy link
Member

@oleq oleq commented Aug 28, 2020 •
edited
Loading

Suggested merge commit message (convention)

Feature (tests): Implemented the toggle button for the manual tests sidebar. Closes ckeditor/ckeditor5#7962.

Additional information

The state of the sidebar is stored in the localStorage.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 87.364% when pulling 07ecea1 on i/7962 into 739bc44 on master.

@oleq oleq mentioned this pull request Aug 28, 2020
Closed
@oleq oleq requested a review from pomek August 28, 2020 15:07
pomek
pomek approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for any feedback from the team until the end of the day and then merge the PR if nobody rejects the changes.

@pomek pomek merged commit e214645 into master Aug 31, 2020
@pomek pomek deleted the i/7962 branch August 31, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomek pomek pomek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let's do something to make the manual test sidebar less annoying
3 participants
@oleq @coveralls @pomek