Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's do something to make the manual test sidebar less annoying #7962

Closed
oleq opened this issue Aug 28, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-dev#666
Closed

Let's do something to make the manual test sidebar less annoying #7962

oleq opened this issue Aug 28, 2020 · 1 comment · Fixed by ckeditor/ckeditor5-dev#666
Assignees
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:dev squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@oleq
Copy link
Member

oleq commented Aug 28, 2020

📝 Provide a description of the improvement

ATM the sidebar is responsive. When the viewport width is less than a fixed number, the sidebar collapses to the left. There are some problems with this approach:

  • Sometimes you have dev tools (e.g. console) open on the right side of the screen and you work with the editor. When you try to re-scale it, for instance, to see a lengthy log, you find out that changing dimensions of the dev tools causes the sidebar to disappear. As a result, the editor content becomes wider and there's a sudden move of the content and the place you were interested in is now hundreds of pixels up the screen.
  • Now the same scenario in the opposite direction: your content was narrow, then you scale dev tools down (to the right) and suddenly the content becomes very wide. 
  • ☝️ These are especially annoying when you debug things like dynamic toolbar grouping. You want to scale the editor up or down fluidly instead of sudden geometry change related to the manual test sidebar.
  • You have to hover the mouse over the sidebar to reveal it. Some of us have docks that show up on hover (like in MacOS, or whatever UI in other OSs) on this side of the screen or just another screen right next to this side of the web browser. I can't tell you how many times I performed the wrong action...
  • The collapsed sidebar looks just weird (a grey bar of 10-20px taking up the entire side of the screen).

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@oleq oleq added type:improvement This issue reports a possible enhancement of an existing feature. domain:dx This issue reports a developer experience problem or possible improvement. squad:platform Issue to be handled by the Platform team. package:dev labels Aug 28, 2020
@oleq oleq added this to the iteration 36 milestone Aug 28, 2020
@oleq oleq self-assigned this Aug 28, 2020
@oleq
Copy link
Member Author

oleq commented Aug 28, 2020

I proposed the following DX/UX in the PR:

pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Aug 31, 2020
Feature (tests): Implemented the toggle button for the manual tests sidebar. Closes ckeditor/ckeditor5#7962.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:dx This issue reports a developer experience problem or possible improvement. package:dev squad:platform Issue to be handled by the Platform team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant