Support for nested indentation on pasted content #94
Conversation
gjhenrique
changed the title
|
Wow :) You're a hero already! :) @ckeditor/qa-team, could you check whether this PR doesn't break something that perhaps worked already? If there are no regressions, even if this PR doesn't handle some things perfectly, I'm all for merging it. @mlewand, I leave the code review to you. Similarly to the QA aspect – as long as there are no major issues, let's merge this. |
|
Hi guys would it be possible to have this changeset released? thank you in advance. |
|
@mlewand, there's a conflict due to changes done by @pomek recently. It should be fairly easy to resolve. @laertispappas, we need to review the code first and once it's done and looks fine, we'll merge the PR. It will be then included in the next release. |
|
@Reinmar Sure, I'll take a look at it tomorrow 👍 |
|
@mlewand |
There was a problem hiding this comment.
Generally looks fine, good job 👍 I can see that you were able to even make the code a little more concise.
That being said new parts will surely have to be adjusted while fixing ckeditor/ckeditor5#6380 - good to see we're closer to that!
|
Awesome news :) Thanks @gjhenrique! 👏 |
Suggested merge commit message (convention)
Feature: Stand on the shoulder of the giant @f1ames to support lists indentation in pasted content added.
Closes ckeditor/ckeditor5#2518
Additional information
We're currently using ckeditor in one of our projects and it's a worderfull library. Thank you for open sourcing it.
Everything works fine, except the support for nested lists is a requirement. I checked that #53 was pending because of the normalization of some items. This PR tries to fix that normalization.
I rebased to master from the existing branch, fixed the conflicts and modified the required code to support it. On top of that, I commited fca9d77 to support the correct normalization.
Lemme know if something is missing
\cc
@Mgsy @Reinmar