[Umbrella] Undo/redo issues #2723

Reinmar · 2017-07-06T16:10:35Z

Since we know that there a lot of issues with undo found after the recent refactoring let's report them in one place.

Reinmar · 2017-07-06T16:11:56Z

Type: Redo, selection restoring

Selection is restored incorrectly:

Reinmar · 2017-07-06T16:14:58Z

FIXED

Rename leaks to a nearby element.

Reinmar · 2017-07-06T16:16:36Z

FIXED

Additional list empty block appears (wrap, split):

Reinmar · 2017-07-06T16:20:43Z

FIXED

Type: Undo, performance

Undo becomes noticeably slow when undoing typing :((((

It seems that typing compression will be a must-have in a short time.

Edit by LukaszGudel: It looks much better now, undoing and redoing typing is almost instant. IMO fixed.

Reinmar · 2017-07-06T16:23:44Z

FIXED

basic-transformations.js:67 Uncaught TypeError: Cannot read property 'getNode' of undefined
    at addTransformationCase (basic-transformations.js:67)
    at Object.transform (transform.js:59)
    at Object.transformDeltaSets (transform.js:268)
    at Document.transformDeltas (document.js:359)
    at RedoCommand._undo (basecommand.js:140)
    at Array.editor.document.enqueueChanges (redocommand.js:42)
    at Document.enqueueChanges (document.js:241)
    at RedoCommand.execute (redocommand.js:36)
    at RedoCommand.on (observablemixin.js:327)
    at RedoCommand.fire (emittermixin.js:281)

scofalik · 2017-07-07T06:03:31Z

Undo becomes noticeably slow when undoing typing :((((

Yes... This was another gain that we got by removing deltas from History. There was much less transformations. I am sure we will spend time on this subject because it cannot work like this. I think there are places where optimisation could be applied, but this needs to be measured and researched.

Later, we can think about some tricks to maybe somehow skip some transformations or something but this has to be:

Done when 99% of cases work (meaning that we solved all issues we know about).
Done very carefully so we won't fall again into some kind of trap like with History.

Reinmar · 2017-07-07T08:21:58Z

FIXED

position.js:158 Uncaught TypeError: this.parent.offsetToIndex is not a function
    at Position.get index [as index] (position.js:158)
    at Position.get textNode [as textNode] (position.js:169)
    at Position.get nodeAfter [as nodeAfter] (position.js:181)
    at _fixItemsIndent (converters.js:629)
    at Document.<anonymous> (converters.js:576)
    at Document.fire (emittermixin.js:281)
    at Document.applyOperation (document.js:173)
    at UndoCommand._undo (basecommand.js:153)
    at Array.editor.document.enqueueChanges (undocommand.js:40)
    at Document.enqueueChanges (document.js:241)

EDIT: This TC is really fragile. You need to be very precise regarding actions.

Reinmar · 2017-07-07T12:32:09Z

As for performance issues. I did a quick check.

Here's a general overview of a single undo step:

20 transformDeltas() calls. Each 10ms. But the further you go back in the undo history, the longer the transformDeltas() calls.

Now, it's very interesting to see what are the widest leafs of this flame chart:

Yep, Position() constructors. If you'll scroll more you'll see that there also other constructors there (and they are similarly long), but the problem is that Position repeats hundreds of times.

So, it's very likely that one of the most important issues https://github.com/ckeditor/ckeditor5-engine/issues/897.

Edit: I did a small check and removed cloning from Position.createFromPosition() but it's too simplistic (because there are two position types). We'd need more time to check what we can gain by avoiding cloning all the time.

Reinmar · 2017-07-10T19:52:15Z

FIXED

Enter
Bold
Forward delete (backspace or fn+delete on macOS)
Undo

ckeditorerror.js:38 Uncaught CKEditorError: model-history-wrong-version: Given base version points to the middle of a delta.
    at History._getIndex (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:41285:10)
    at History.getDeltas (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:41187:24)
    at getDeltas.next (<anonymous>)
    at Function.from (native)
    at UndoCommand._undo (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:29872:32)
    at Array.editor.document.enqueueChanges (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:47229:30)
    at Document.enqueueChanges (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:40085:30)
    at UndoCommand.execute (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:47228:24)
    at UndoCommand.on (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:5973:32)
    at UndoCommand.fire (http://localhost:8125/ckeditor5-presets/tests/manual/article.js:4267:29)

The above error was reproduced on branch with a fix for https://github.com/ckeditor/ckeditor5-engine/issues/1001. On the current master first undo works, but the second gives:

basic-transformations.js:67 Uncaught TypeError: Cannot read property 'getNode' of undefined
    at addTransformationCase (basic-transformations.js:67)
    at Object.transform (transform.js:59)
    at Object.transformDeltaSets (transform.js:261)
    at Document.transformDeltas (document.js:359)
    at UndoCommand._undo (basecommand.js:140)
    at Array.editor.document.enqueueChanges (undocommand.js:40)
    at Document.enqueueChanges (document.js:241)
    at UndoCommand.execute (undocommand.js:39)
    at UndoCommand.on (observablemixin.js:327)
    at UndoCommand.fire (emittermixin.js:281)

Reinmar · 2017-07-13T16:07:29Z

FIXED

Type: Undo, incorrect data

This is not a regression but it's a bug worth checking anyway.

Edit by LukaszGudel: Undo block quote is now correctly creating 2 nested list items. Fixed.

scofalik · 2017-07-14T05:42:15Z

The above might be one of "cannot fix with how converters work now" bug. There are actually 6 tests in integration of undo with lists that are intentionally skipped because they are failing. These are the cases that cannot be (at least easily) solved with current state of how conversion works. We skipped them to deliver Nested Lists feature faster.

If we change conversion to happen on changesDone those cases will be probably easier to solve and then we can get back to them.

Mgsy · 2017-07-17T11:34:53Z

FIXED

Steps to reproduce

Load the clipboard plugin to the markers test.
Go to http://localhost:8125/ckeditor5-engine/tests/manual/markers.html
Create 2 lines of text.
Select them and press Ctrl + C.
Put the caret inside the marker.
Press Ctrl + V.
Press Ctrl + Z.

Current result

Some part of the marker and text is lost
There is the error in the console

GIF

Error

position.js:221 Uncaught TypeError: Cannot read property 'root' of undefined
    at Position.compareWith (position.js:221)
    at Position.isEqual (position.js:411)
    at addTransformationCase (basic-transformations.js:396)
    at Object.transform (transform.js:59)
    at Object.transformDeltaSets (transform.js:261)
    at Document.transformDeltas (document.js:359)
    at UndoCommand._undo (basecommand.js:140)
    at Array.editor.document.enqueueChanges (undocommand.js:40)
    at Document.enqueueChanges (document.js:241)
    at UndoCommand.execute (undocommand.js:39)

Other information

OS: Windows 10, MacOS X
Browser: Chrome, Safari, Edge, Firefox, Opera
Release: 0.10.0

Reinmar · 2017-08-09T08:31:32Z

FIXED

Copy all.
Paste at the end of the content.
Undo.

position.js:221 Uncaught TypeError: Cannot read property 'root' of undefined
    at Position.compareWith (position.js:221)
    at Position.isEqual (position.js:411)
    at addTransformationCase (basic-transformations.js:402)
    at Object.transform (transform.js:59)
    at Object.transformDeltaSets (transform.js:261)
    at Document.transformDeltas (document.js:359)
    at UndoCommand._undo (basecommand.js:140)
    at Array.editor.document.enqueueChanges (undocommand.js:40)
    at Document.enqueueChanges (document.js:241)
    at UndoCommand.execute (undocommand.js:39)

Mgsy · 2017-08-09T12:15:03Z

FIXED

Steps to reproduce

Put the caret at the beginning of the paragraph.
Press Enter.
Press Ctrl + Z.

Current result

The caret was moved to the end of the paragraph.

GIF

scofalik · 2017-08-09T12:18:52Z

Selection restoring doesn't work correctly, we know about it and will change it, hopefully soon.

scofalik · 2017-08-10T08:12:10Z

After I fixed this issue: https://github.com/ckeditor/ckeditor5-undo/issues/65#issuecomment-321190168 I noticed that undo+redo creates different content than it was at the beginning. It's worth to check why it happens. It fails even for fairly non-complicated copy paste. It has to be checked whether there is a bug in: copy/paste, OT or converters and whether this happens only for content with lists or also in other cases.

EDIT: Looks like it happens for copy paste whenever pasting is not into an empty element.

Mgsy · 2017-08-16T09:27:00Z

FIXED | Type: Redo, incorrect data

Block quote is removed after undo/redo operations.

Steps to reproduce

Create new paragraph and new block quote.
Put the caret at the end of the paragraph.
Press Delete.
Press Ctrl + Z.
Ctrl + Y.

GIF

Mgsy · 2017-08-17T08:03:39Z

FIXED | Type: Undo, incorrect data

Steps to reproduce

Create two block elements, i.e. paragraphs.
Put the caret at the end of the first paragraph.
Press Enter.
Press Delete.
Press Ctrl + Z twice.

Current result

The second paragraph has been removed.

GIF

Mgsy · 2017-08-17T08:59:18Z

FIXED

Steps to reproduce

Create the empty paragraph.
Press Ctrl + B.
Type something.
Put the caret at the middle of the word.
Press Enter.
Press Undo 4 times.

Current result

There is the error in the console.

Error

basic-transformations.js:270 Uncaught TypeError: Cannot read property 'root' of null
    at addTransformationCase (basic-transformations.js:270)
    at Object.transform (transform.js:59)
    at Object.transformDeltaSets (transform.js:261)
    at Document.transformDeltas (document.js:359)
    at UndoCommand._undo (basecommand.js:140)
    at Array.editor.document.enqueueChanges (undocommand.js:40)
    at Document.enqueueChanges (document.js:241)
    at UndoCommand.execute (undocommand.js:39)
    at UndoCommand.on (observablemixin.js:327)
    at UndoCommand.fire (emittermixin.js:281)

GIF

Mgsy · 2017-08-21T08:38:00Z

FIXED | Type: Undo, incorrect data

Steps to reproduce

Put the caret at the middle of some word, i.e. paragraph.
Press Enter.
Make the following selection:

parag{
raph}

Press Delete.
Press Ctrl + Z twice.

Current result

Undo doesn't merge the word.

GIF

Mgsy · 2017-09-12T09:03:47Z

FIXED | Type: Redo, selection restoring

Steps to reproduce

Create the paragraph below the block quote.
Type something.
Put the caret at the beginning of the paragraph.
Press Backspace.
Press Ctrl + Z.
Press Ctrl + Y.

Current result

Block quote was applied to the paragraph instead of moving paragraph to the end of the block quote.

GIF

Fix: Undo did no changes instead of merging elements, in a scenario when an element was split and then the "new" element was removed. See https://github.com/ckeditor/ckeditor5-undo/issues/65#issuecomment-323682195.

Reinmar · 2017-09-29T15:46:02Z

FIXED | Type: Undo, incorrect data, crash

See https://github.com/ckeditor/ckeditor5-engine/issues/1152

Mgsy · 2017-10-11T08:58:07Z

Type: Redo, selection restoring

Steps to reproduce

Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
Copy two block elements.
Create new empty line.
Press Ctrl + V.
Press Ctrl + Z.
Press Ctrl + Y.

GIF

Mgsy · 2017-10-11T09:45:19Z

Fixed

Type: Undo, incorrect data

Steps to reproduce

Create new block quote.
Inside the QB create the list with one nested item.
Select whole list.
Press Delete.
Press Ctrl + Z.

GIF

Edit by LukaszGudel: Undoing list removal is now correctly restoring two items without adding third one. Fixed.

Mgsy · 2017-10-11T13:38:53Z

POSSIBLY FIXED

Type: Redo, crash

Steps to reproduce

Create new blockquote below other block element.
Type some word.
Split it.
Select divided word.
Press Delete.
Undo.
Redo.
Press Backspace.

Error

ckeditor.js:5 Uncaught o: move-operation-node-into-itself: Trying to move a range of nodes into one of nodes from that range. Read more: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/framework/guides/support/error-codes.html#move-operation-node-into-itself.
    at d._execute (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:50554)
    at x.applyOperation (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:246675)
    at n (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:107507)
    at o.move (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:108252)
    at n (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:242104)
    at t.a (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:243111)
    at _.deleteContent (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:222073)
    at _.on (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:29276)
    at _.fire (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:23735)
    at _.(anonymous function) [as deleteContent] (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:29327)

GIF

Edit by LukaszGudel: I can not recreate this issue using those steps. It's possible that it is fixed but it would be better if someone confirms this.

Mgsy · 2017-10-13T09:21:09Z

FIXED

Type: Undo, incorrect data

Steps to reproduce

Put the caret in the middle of some word.
Press Enter.
Select divided parts.
Press Delete.
Add the block quote.
Undo twice.

Current result

Divided word is missing bottom part.

GIF

Edit by LukaszGudel: Undoing is correctly restoring both lines. Fixed.

Mgsy · 2017-10-13T11:19:28Z

FIXED

Type: undo, incorrect data

Steps to reproduce

Type test.
Put the caret after t and press Enter.
Repeat step 2 for every character. You should receive:

t
e
s
t

Delete every character, starting from the last one.
Put the caret at the last empty line.
Press Backspace 3 times.
Undo until word is restored.

Current result

Word has been restored, but characters have incorrect position - the result is tets, instead of test.

GIF

Edit by LukaszGudel: word is correctly restored with correct position of characters.

Mgsy · 2017-10-13T12:30:30Z

Fixed

Type: Undo, incorrect data

Steps to reproduce

Create two paragraphs with some words.
Put the caret at the second paragraph.
Transform it into the block quote.
Select the word inside the block quote.
Press Backspace 3 times.
Undo.

Current result

Deleted character from the first paragraph has been restored inside the block quote.

GIF

Edit by LukaszGudel: Words are correctly restored. Fixed.

Mgsy · 2017-10-13T13:21:50Z

POSSIBLY FIXED

Type: Undo, crash

Steps to reproduce

Create two paragraphs with some words.
Put the caret at the second paragraph.
Transform it into the Heading 1.
Select this word.
Press Backspace 3 times.
Undo.

Current result

Editor crashes.

GIF

Edit by LukaszGudel: I can not recreate this issue using those steps. It's possible that it is fixed but it would be better if someone confirms this.

Mgsy · 2017-10-13T14:25:26Z

POSSIBLY FIXED

Type: Undo, crash

Steps to reproduce

Select two block elements.
Click on the block quote icon.
Press Delete.
Click on the block quote icon.
Undo twice.

Current result

Editor crashes

GIF

Error

ckeditor.js:5 Uncaught o: move-operation-position-invalid: Source position or target position is invalid. Read more: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/framework/guides/support/error-codes.html#move-operation-position-invalid.
    at i._execute (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:49878)
    at x.applyOperation (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:246824)
    at o._undo (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:202841)
    at Array.editor.document.enqueueChanges (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:336109)
    at x.enqueueChanges (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:247377)
    at o.execute (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:336076)
    at on (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:29255)
    at o.fire (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:23714)
    at o.(anonymous function) [as execute] (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:29306)
    at o.execute (http://192.168.20.68:8125/ckeditor5-build-classic/tests/manual/ckeditor.js:75:220184)

Edit by LukaszGudel: I can not recreate this issue using those steps. It's possible that it is fixed but it would be better if someone confirms this.

Mgsy · 2017-10-16T08:03:02Z

Fixed

Type: Undo, incorrect data

Steps to reproduce

Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
Put the caret at the end of the Heading 1.
Press Enter.
Press Backspace.
Delete the word character by character with Backspace.
Undo.

Current result

First character of the word has been moved to the new line.

GIF

Edit by LukaszGudel: Text in heading is correctly restored. Fixed.

Mgsy · 2017-10-16T12:20:40Z

POSSIBLY FIXED

Type: Undo, crash

Steps to reproduce

Create 3 paragraphs with some text.
Select first paragraph and press Delete twice.
Select first remained paragraph and part of the second one and press Delete.
Transform remained paragraph into the list.
Undo 3 times.

Current result

Editor crashes.

GIF

Error

ckeditorerror.js:46 Uncaught CKEditorError: model-position-path-incorrect: Position path must be an array with at least one item. Read more: https://ckeditor5.github.io/docs/nightly/ckeditor5/latest/framework/guides/support/error-codes.html#model-position-path-incorrect.
 {"path":[]}
    at new Position (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:237:10)
    at addTransformationCase (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:47295:24)
    at Object.transform (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:31648:23)
    at Object.transformDeltaSets (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:31851:34)
    at Document.transformDeltas (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:42588:77)
    at UndoCommand._undo (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:36858:37)
    at Array.editor.document.enqueueChanges (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:55081:30)
    at Document.enqueueChanges (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:42470:30)
    at UndoCommand.execute (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:55080:24)
    at UndoCommand.on (http://192.168.20.68:8125/ckeditor5-core/tests/manual/article.js:5873:32)

Edit by LukaszGudel: I can not recreate this issue using those steps. It's possible that it is fixed but it would be better if someone confirms this.

Mgsy · 2017-10-16T13:38:16Z

FIXED

Type: Undo, incorrect data

Steps to reproduce

Create 3 paragraphs with some text.
Select first paragraph and press Delete twice.
Select remained paragraphs.
Press Delete.
Undo twice.

Current result

The word from the second paragraph has been moved to the third paragraph.

GIF

Edit by LukaszGudel: paragraphs are correctly restored.

Mgsy · 2017-10-17T08:05:35Z

FIXED

Type: Undo, selection restoring, incorrect data

Steps to reproduce

Create two paragraphs with some words.
Put the caret inside the word from the second paragraph.
Press Backspace twice.
Put the caret at the end of the first paragraph.
Press Delete.
Repeat step 4.
Press and hold Backspace to delete whole word.
Undo 3 times.

Current result

Characters deleted in step 3 appeared in the first paragraph.

GIF

Edit by LukaszGudel: Paragraphs are correctly restored. Fixed

scofalik · 2017-10-17T10:26:55Z

I have a feeling that many new errors connected with Undo are regressions after a change in deleteContents we merged very recently. I am sure that at least one of them is, as I tested it. This means that we will have to solve this in OT, or revert the change.

Reinmar · 2017-10-17T10:53:46Z

Could you report this in the engine and check it there?

scofalik · 2017-10-27T13:22:05Z

Type: Redo, incorrect data

Steps to reproduce

Create content with three <p>s.
Select whole content and wrap it in blockquote.
Put caret in the middle paragraph.
Unwrap it from blockquote.
Undo, undo.
Redo, redo

Current result

The unwrapped paragraph is moved to the beginning.

GIF

Edit by LukaszGudel: Current behaviour is slightly different.

Mgsy · 2017-10-31T09:38:06Z

FIXED

Type: Redo, selection restoring

Steps to reproduce

Create three block quotes.
Select them.
Press Delete.
Undo until they disappear.
Redo to restore removed block quotes.

Current result

Block quotes have been restored in reversed order.

GIF

Edit by LukaszGudel: Blocks are restored in correct order.

Mgsy · 2017-10-31T10:23:18Z

Fixed

Type: Undo, incorrect data

Steps to reproduce

Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
Put the caret after H at Heading 1.
Split the word with Enter.
Put the caret at the end of the second divided part.
Press Backspace.
Repeat step 4 and 5 for the first divided part.
Put the caret at the end of the second divided part.
Press Backspace 8 times.
Undo until word is restored.

Current result

Word has been restored incorrectly.

GIF

Edit by LukaszGudel: Characters in heading are correctly restored.

Mgsy · 2018-01-08T11:57:09Z

Fixed

Type: Undo, incorrect data

Steps to reproduce

Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
Start the selection from the end of the OL List item 2 and drag it to the first Quote.
Apply the block quote.
Undo.

Current result

Whole block quote has disappeared.

GIF

Edit by Lukasz Gudel: Content looks the same as before applying block quote. There is no content lost. Fixed.

Mgsy · 2018-01-08T12:57:10Z

POSSIBLY FIXED

Type: Undo, crash

Steps to reproduce

Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
Delete whole content.
Create the block quote with two empty paragraphs.
Put the caret at the first paragraph.
Click on the block quote icon.
Undo.

Current result

Editor crashes

Error

mapper.js:398 Uncaught TypeError: Cannot read property 'is' of undefined
    at Mapper._findPositionIn (mapper.js:398)
    at Mapper.on (mapper.js:73)
    at Mapper.fire (emittermixin.js:269)
    at Mapper.toViewPosition (mapper.js:237)
    at ModelConversionDispatcher.<anonymous> (model-selection-to-view-converters.js:86)
    at ModelConversionDispatcher.fire (emittermixin.js:269)
    at ModelConversionDispatcher.convertSelection (modelconversiondispatcher.js:253)
    at Model.EditingController.listenTo (editingcontroller.js:126)
    at Model.fire (emittermixin.js:269)
    at Model._runPendingChanges (model.js:209)

Notes

Here is the first bad commit - ckeditor/ckeditor5-image@7a1ab67

GIF

Edit by LukaszGudel: I can not recreate this issue using those steps. It's possible that it is fixed but it would be better if someone confirms this.

scofalik · 2018-02-19T09:30:56Z

FIXED

Type: Undo, incorrect data

Steps to reproduce

Open http://localhost:8125/ckeditor5-core/tests/manual/article.html
Place caret at the end of the second line.
Press and keep backspace to delete text up to the beginning of the document.
Press Undo.

Current result

The content is different than at the beginning

Expected result

After undo the content is same as before deleting the text

Edit by LukaszGudel: Content is the same as before deleting the text. Fixed.

CKEditorBot · 2023-10-02T05:19:37Z

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

CKEditorBot · 2023-11-02T05:16:14Z

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

Reinmar changed the title ~~[Umberlla] Issues with undo~~ [Umberlla] Undo issues Jul 6, 2017

Reinmar changed the title ~~[Umberlla] Undo issues~~ [Umberlla] Undo/redo issues Jul 6, 2017

Reinmar changed the title ~~[Umberlla] Undo/redo issues~~ [Umbrella] Undo/redo issues Jul 10, 2017

mlewand transferred this issue from ckeditor/ckeditor5-undo Oct 9, 2019

mlewand added the package:undo label Oct 9, 2019

mlewand added this to the backlog milestone Oct 9, 2019

mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. labels Oct 9, 2019

stamch13 mentioned this issue Dec 12, 2019

"Blockquote" plugin iconsistent model state, when executing undo, redo #5966

Closed

mlewand removed the status:confirmed label Mar 18, 2020

Reinmar added the squad:core Issue to be handled by the Core team. label Nov 3, 2021

pomek removed this from the backlog milestone Feb 21, 2022

CKEditorBot added the status:stale label Oct 2, 2023

CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 2, 2023

CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023

[Umbrella] Undo/redo issues #2723

[Umbrella] Undo/redo issues #2723

Comments

Reinmar commented Jul 6, 2017 • edited by LukaszGudel Loading

Reinmar commented Jul 6, 2017 • edited by Mgsy Loading

Type: Redo, selection restoring

Reinmar commented Jul 6, 2017 • edited by Mgsy Loading

FIXED

Reinmar commented Jul 6, 2017 • edited by Mgsy Loading

FIXED

Reinmar commented Jul 6, 2017 • edited by LukaszGudel Loading

FIXED

Type: Undo, performance

Reinmar commented Jul 6, 2017 • edited by Mgsy Loading

FIXED

scofalik commented Jul 7, 2017 • edited Loading

Reinmar commented Jul 7, 2017 • edited by Mgsy Loading

FIXED

Reinmar commented Jul 7, 2017 • edited Loading

Reinmar commented Jul 10, 2017 • edited by Mgsy Loading

FIXED

Reinmar commented Jul 13, 2017 • edited by LukaszGudel Loading

FIXED

Type: Undo, incorrect data

scofalik commented Jul 14, 2017

Mgsy commented Jul 17, 2017 • edited Loading

FIXED

Steps to reproduce

Current result

GIF

Error

Other information

Reinmar commented Aug 9, 2017 • edited by Mgsy Loading

FIXED

Mgsy commented Aug 9, 2017 • edited Loading

FIXED

Steps to reproduce

Current result

GIF

scofalik commented Aug 9, 2017

scofalik commented Aug 10, 2017 • edited Loading

Mgsy commented Aug 16, 2017 • edited Loading

FIXED | Type: Redo, incorrect data

Steps to reproduce

GIF

Mgsy commented Aug 17, 2017 • edited Loading

FIXED | Type: Undo, incorrect data

Steps to reproduce

Current result

GIF

Mgsy commented Aug 17, 2017 • edited Loading

FIXED

Steps to reproduce

Current result

Error

GIF

Mgsy commented Aug 21, 2017 • edited by Reinmar Loading

FIXED | Type: Undo, incorrect data

Steps to reproduce

Current result

GIF

Mgsy commented Sep 12, 2017 • edited Loading

FIXED | Type: Redo, selection restoring

Steps to reproduce

Current result

GIF

Reinmar commented Sep 29, 2017 • edited by Mgsy Loading

FIXED | Type: Undo, incorrect data, crash

Mgsy commented Oct 11, 2017

Type: Redo, selection restoring

Steps to reproduce

GIF

Mgsy commented Oct 11, 2017 • edited by LukaszGudel Loading

Fixed

Type: Undo, incorrect data

Steps to reproduce

GIF

Mgsy commented Oct 11, 2017 • edited by LukaszGudel Loading

POSSIBLY FIXED

Type: Redo, crash

Reinmar commented Jul 6, 2017 •

edited by LukaszGudel

Loading

Reinmar commented Jul 6, 2017 •

edited by Mgsy

Loading

Reinmar commented Jul 6, 2017 •

edited by Mgsy

Loading

Reinmar commented Jul 6, 2017 •

edited by Mgsy

Loading

Reinmar commented Jul 6, 2017 •

edited by LukaszGudel

Loading

Reinmar commented Jul 6, 2017 •

edited by Mgsy

Loading

scofalik commented Jul 7, 2017 •

edited

Loading

Reinmar commented Jul 7, 2017 •

edited by Mgsy

Loading

Reinmar commented Jul 7, 2017 •

edited

Loading

Reinmar commented Jul 10, 2017 •

edited by Mgsy

Loading

Reinmar commented Jul 13, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Jul 17, 2017 •

edited

Loading

Reinmar commented Aug 9, 2017 •

edited by Mgsy

Loading

Mgsy commented Aug 9, 2017 •

edited

Loading

scofalik commented Aug 10, 2017 •

edited

Loading

Mgsy commented Aug 16, 2017 •

edited

Loading

Mgsy commented Aug 17, 2017 •

edited

Loading

Mgsy commented Aug 17, 2017 •

edited

Loading

Mgsy commented Aug 21, 2017 •

edited by Reinmar

Loading

Mgsy commented Sep 12, 2017 •

edited

Loading

Reinmar commented Sep 29, 2017 •

edited by Mgsy

Loading

Mgsy commented Oct 11, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 11, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 13, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 13, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 13, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 13, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 13, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 16, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 16, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 16, 2017 •

edited by LukaszGudel

Loading

Mgsy commented Oct 17, 2017 •

edited by LukaszGudel

Loading

scofalik commented Oct 27, 2017 •

edited by LukaszGudel

Loading