Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHS: Support for <colgroup> and <col> attributes #11479

Closed
jswiderski opened this issue Mar 17, 2022 · 0 comments · Fixed by #13328
Closed

GHS: Support for <colgroup> and <col> attributes #11479

jswiderski opened this issue Mar 17, 2022 · 0 comments · Fixed by #13328
Assignees
@filipsobol
Labels
package:html-support squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 61 (v37...

Comments

@jswiderski
Copy link

jswiderski commented Mar 17, 2022 •
edited by Mgsy
Loading

📝 Provide a description of the new feature

Currently, <colgroup> and <col> elements are introduced by the Table resize feature. However, it seems that attributes are lost, even if we allow all in GHS.

This feature request is about preserving attributes with GHS on <colgroup> and <col> elements.

If you'd like to see this feature implemented, add a 👍 reaction to this post.
@jswiderski jswiderski added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Mar 17, 2022
@Reinmar Reinmar added package:html-support squad:core Issue to be handled by the Core team. labels Mar 17, 2022
@martynawierzbicka martynawierzbicka added the support:2 An issue reported by a commercially licensed client. label Mar 18, 2022
@Mgsy Mgsy changed the title Support for <colgroup> and <col> elements GHS: Support for <colgroup> and <col> attributes Dec 1, 2022
@filipsobol filipsobol self-assigned this Jan 12, 2023
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jan 16, 2023
@filipsobol filipsobol mentioned this issue Jan 24, 2023
Merged
niegowski added a commit that referenced this issue Feb 9, 2023
@niegowski
Merge pull request #13328 from ckeditor/ck/11479-add-tableColumnGroup…
61debdc 
…-and-tableColumn-elements-to-model

Fix (html-support): Attributes on the `<colgroup>`, and `<col>` elements should be preserved in the data. Closes #11479.

Other (table): The table columns' widths are stored as model elements instead of model element attributes. See #11479.

Fix (engine): The `elementToStructure()` downcast helper should not skip attribute changes that happened with the modification of the children list.

MINOR BREAKING CHANGE (table): The table columns' widths are stored as model elements instead of model element attribute. See #11479.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Feb 9, 2023
@CKEditorBot CKEditorBot added this to the iteration 61 milestone Feb 9, 2023
@Reinmar Reinmar mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipsobol filipsobol

Labels
package:html-support squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 61 (v37.0.0)
5 participants
@Reinmar @filipsobol @jswiderski @CKEditorBot @martynawierzbicka