Introduce <tableColumnGroup> and <tableColumn> elements to store columns width information
#13328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…columns width information
filipsobol
force-pushed
the
ck/11479-add-tableColumnGroup-and-tableColumn-elements-to-model
branch
from
950f179 to
0ed0d5c
Compare
…olumnGroup-and-tableColumn-elements-to-model
… on the same node.
…o the re-converted element.
…to-model' of https://github.com/ckeditor/ckeditor5 into ck/11479-add-tableColumnGroup-and-tableColumn-elements-to-model
…umn-elements-to-model
…ould handle other attributes.
niegowski
requested changes
Feb 6, 2023
packages/ckeditor5-table/src/tablecolumnresize/tablecolumnresizeediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/src/tablecolumnresize/tablecolumnresizeediting.js
Show resolved
Hide resolved
packages/ckeditor5-table/tests/tablecolumnresize/tablewidthscommand.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/tests/tablecolumnresize/tablewidthscommand.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/tests/tablecolumnresize/tablecolumnresizeediting.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/tests/tablecolumnresize/tablewidthscommand.js
Outdated
Show resolved
Hide resolved
packages/ckeditor5-table/tests/tablecolumnresize/tablewidthscommand.js
Outdated
Show resolved
Hide resolved
|
Also we should have tests for the original issue (GHS attributes on colgroup and col). |
niegowski
approved these changes
Feb 9, 2023
niegowski
deleted the
ck/11479-add-tableColumnGroup-and-tableColumn-elements-to-model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix (html-support): Attributes on the
<colgroup>, and<col>elements should be preserved in the data. Closes #11479.Other (table): The table columns' widths are stored as model elements instead of model element attributes. See #11479.
Fix (engine): The
elementToStructure()downcast helper should not skip attribute changes that happened with the modification of the children list.MINOR BREAKING CHANGE (table): The table columns' widths are stored as model elements instead of model element attribute.