Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if a package is published when npm says "OK" #17322

Closed
pomek opened this issue Oct 25, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#1035
Closed

Verify if a package is published when npm says "OK" #17322

pomek opened this issue Oct 25, 2024 · 0 comments · Fixed by ckeditor/ckeditor5-dev#1035
Assignees
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@pomek
Copy link
Member

pomek commented Oct 25, 2024

Provide a description of the task

The latest nightly build results in weird cases.

The packages listed below haven't been published despite a job log containing nothing about them. In other words, npm said OK when we called npm publish even if packages were unavailable.

[
  '@ckeditor/ckeditor5-utils',
  '@ckeditor/ckeditor5-ui',
  '@ckeditor/ckeditor5-typing',
  '@ckeditor/ckeditor5-table',
  '@ckeditor/ckeditor5-style',
  '@ckeditor/ckeditor5-special-characters',
  '@ckeditor/ckeditor5-mention',
  '@ckeditor/ckeditor5-link',
  '@ckeditor/ckeditor5-font',
  '@ckeditor/ckeditor5-editor-decoupled',
  '@ckeditor/ckeditor5-editor-classic',
  '@ckeditor/ckeditor5-code-block',
  '@ckeditor/ckeditor5-build-multi-root',
  '@ckeditor/ckeditor5-slash-command',
  '@ckeditor/ckeditor5-paste-from-office-enhanced',
  '@ckeditor/ckeditor5-pagination',
  '@ckeditor/ckeditor5-merge-fields',
  '@ckeditor/ckeditor5-import-word',
  '@ckeditor/ckeditor5-format-painter',
  '@ckeditor/ckeditor5-comments'
]

Also, the same log contains many (18x) E409 errors handled correctly this time.

Example: @ckeditor/ckeditor5-editor-multi-root

Image

Image

It looks like we cannot trust any response npm sends.

Let's verify an upload status manually, as we do when an error occurs. This line should be removed:

https://github.com/ckeditor/ckeditor5-dev/blob/6e47a6d46ca1511ac2eb56bf05c7692412971711/packages/ckeditor5-dev-release-tools/lib/utils/publishpackageonnpmcallback.js#L25

Related issues

@pomek pomek added package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos". labels Oct 25, 2024
@pomek pomek self-assigned this Oct 25, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 25, 2024
pomek added a commit to ckeditor/ckeditor5-dev that referenced this issue Oct 25, 2024
Internal: Changelog for v45.0.2.

Internal: The `publishPackageOnNpmCallback()` util does not remove a package directory even if npm says it was published. Closes ckeditor/ckeditor5#17322.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Oct 25, 2024
@CKEditorBot CKEditorBot added this to the iteration 80 milestone Oct 25, 2024
psmyrek added a commit to ckeditor/ckeditor5-dev that referenced this issue Oct 29, 2024
…ve a package directory even if npm says it was published. Closes ckeditor/ckeditor5#17322."

This reverts commit a1b37c7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:dev squad:platform Issue to be handled by the Platform team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants