Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused gulp tasks and rethink node.js testing tasks location #281

Closed
szymonkups opened this issue Aug 4, 2016 · 5 comments
Closed
Assignees
Milestone

Comments

@szymonkups
Copy link
Contributor

szymonkups commented Aug 4, 2016

After we moved all development utils to ckeditor5-dev-env repository there are unused gulp tasks inside: dev/tasks/test:

  • gulp test:dev
  • gulp test:dev:coverage

Those tasks should be removed from the main repository as there are no dev tasks to test.

There are also tasks that tests our code under node.js environment. Those tasks use bender configuration. We can leave them inside main repository or move them to the ckeditor-dev-env. In the latter case bender configuration should be passed there as a parameter.

I am not quite sure where is proper place for these tasks.

@szymonkups szymonkups added this to the iteration 2 milestone Aug 4, 2016
@szymonkups
Copy link
Contributor Author

szymonkups commented Aug 4, 2016

If we decide to move these tasks to ckeditor-dev-env, we will be able to remove gulp- dependencies from main repository. Only gulp and run-sequence will be left I think.

@maxbarnas
Copy link
Contributor

maxbarnas commented Aug 4, 2016

I am thinking about moving this in-node editor testing (along with its unit tests) to ckeditor5-dev-builder.

Reasons? Testing in node is based pretty much on modifying CKEditor build. Similarity is thin, but the best I could find.

@szymonkups
Copy link
Contributor Author

I moved this task to iteration 3, we will decide if we want to keep this in main package or move it somewhere else.

@Reinmar
Copy link
Member

Reinmar commented Aug 12, 2016

For now, I'd remove this code as we don't use this task, unfortunately. We wanted to understand what piece of code will work under Node, but this proved to be too high cost to continue doing that in a long run. We can bring back the code once we have CI which will do the testing for us.

@szymonkups
Copy link
Contributor Author

Reminder to update wiki and remove gulp test:* tasks description from wiki after closing this.

mlewand pushed a commit that referenced this issue May 1, 2020
Tests: Added the select all icon to the "iconset" manual test (see #6536).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants