Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Ctrl/Cmd+A when a widget is at the beginning or end of the content #6536

Closed
Reinmar opened this issue Apr 2, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-select-all#1
Closed

Handle Ctrl/Cmd+A when a widget is at the beginning or end of the content #6536

Reinmar opened this issue Apr 2, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-select-all#1
Assignees
@oleq
Labels
type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 2, 2020

Currently, the native Ctrl+A is broken in Chrome when a widget is at the end/start of the root. If we handled this manually, then it would most likely work just fine. Let's try this, especially that we already handle Ctrl+A in nested editables.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@Reinmar Reinmar added the type:bug This issue reports a buggy (incorrect) behavior. label Apr 2, 2020
@Reinmar Reinmar added this to the iteration 31 milestone Apr 2, 2020
This was referenced Apr 14, 2020
Merged
Merged
Merged
Merged
Reinmar added a commit to ckeditor/ckeditor5-select-all that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #1 from ckeditor/i/6536
f0c49d3 
Feature: Implemented the select all feature. Closes ckeditor/ckeditor5#6536.
Reinmar added a commit to ckeditor/ckeditor5-theme-lark that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #281 from ckeditor/i/6536
b5e4754 
Tests: Added the select all icon to the "iconset" manual test (see ckeditor/ckeditor5#6536).
Reinmar added a commit to ckeditor/ckeditor5-widget that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #121 from ckeditor/i/6536
57eb263 
Other: Moved the <kbd>Ctrl</kbd>+<kbd>A</kbd> keystroke handling in widgets to the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin (see ckeditor/ckeditor5#6536).

MINOR BREAKING CHANGE: Make sure the latest version of the [`Essentials`](https://ckeditor.com/docs/ckeditor5/latest/api/essentials.html) plugin or the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin is installed in your integration. Either is required for proper keystroke handling in editor widgets.
Reinmar added a commit to ckeditor/ckeditor5-essentials that referenced this issue Apr 17, 2020
@Reinmar
Merge pull request #7 from ckeditor/i/6536
253d4a0 
Feature: Added the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin to the list of essential editor features (see ckeditor/ckeditor5#6536).
@mlewand mlewand changed the title Handle Ctrl/Cmd+A in a root Handle Ctrl/Cmd+A when a widget is at the beginning or end of the content Apr 24, 2020
@mlewand mlewand mentioned this issue Apr 24, 2020
Closed
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #1 from ckeditor/i/6536
4bae781 
Feature: Implemented the select all feature. Closes #6536.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #281 from ckeditor/i/6536
89b199d 
Tests: Added the select all icon to the "iconset" manual test (see #6536).
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #121 from ckeditor/i/6536
414f64b 
Other: Moved the <kbd>Ctrl</kbd>+<kbd>A</kbd> keystroke handling in widgets to the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin (see #6536).

MINOR BREAKING CHANGE: Make sure the latest version of the [`Essentials`](https://ckeditor.com/docs/ckeditor5/latest/api/essentials.html) plugin or the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin is installed in your integration. Either is required for proper keystroke handling in editor widgets.
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #7 from ckeditor/i/6536
e54c4c4 
Feature: Added the [`SelectAll`](https://ckeditor.com/docs/ckeditor5/latest/api/module_select-all_selectall-SelectAll.html) plugin to the list of essential editor features (see #6536).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

i/6536: Implemented the select all feature ckeditor/ckeditor5-select-all
2 participants
@Reinmar @oleq