Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Shift+arrows inside table cells #3203

Closed
Reinmar opened this issue Jun 18, 2018 · 1 comment · Fixed by #6728
Closed

Handle Shift+arrows inside table cells #3203

Reinmar opened this issue Jun 18, 2018 · 1 comment · Fixed by #6728
Labels
package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 32 (v19...

Comments

@Reinmar
Copy link
Member

Reinmar commented Jun 18, 2018

While reviewing selection post-fixer I found out that the biggest problem with it is how it fixes selection made by Shift+arrow if it started inside a table cell.

The expected result is that once you reach a cell's limit we either:

I described how we can implement it in ckeditor/ckeditor5-engine#1431 (comment).
@Reinmar
Copy link
Member Author

Reinmar commented Jun 18, 2018

There's a more general ticket about the same behaviours in widgets: https://github.com/ckeditor/ckeditor5-widget/issues/42.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-table Oct 9, 2019
@mlewand mlewand added this to the nice-to-have milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:table labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue May 6, 2020
Closed
@niegowski niegowski mentioned this issue May 6, 2020
Merged
jodator added a commit that referenced this issue May 7, 2020
@jodator
Merge pull request #6728 from ckeditor/i/6115
b567de4 
Feature (table): Introduce table cells selection using keyboard. Closes #6115. Closes #3203.
@Reinmar Reinmar modified the milestones: nice-to-have, iteration 32 May 7, 2020
@Reinmar Reinmar added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:table resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 32 (v19.1.0)
Development

Successfully merging a pull request may close this issue.

I/6115: Table cells selection with keyboard. ckeditor/ckeditor5
2 participants
@Reinmar @mlewand