Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I/6115: Table cells selection with keyboard. #6728

Merged
merged 6 commits into from
May 7, 2020
Merged

I/6115: Table cells selection with keyboard. #6728

merged 6 commits into from
May 7, 2020

Conversation

niegowski
Copy link
Contributor

@niegowski niegowski commented May 4, 2020 •
edited
Loading

Suggested merge commit message (convention)

Feature (table): Table cells selection with keyboard. Closes #6115. Closes #3203.

Additional information

@niegowski
Copy link
Contributor Author

Moved from ckeditor/ckeditor5-table#313.

@niegowski niegowski mentioned this pull request May 4, 2020
Closed
@niegowski niegowski changed the title Table cells selection with keyboard. I/6641: Table cells selection with keyboard. May 4, 2020
@niegowski niegowski changed the title I/6641: Table cells selection with keyboard. I/6115: Table cells selection with keyboard. May 4, 2020
@niegowski niegowski changed the base branch from i/6641 to master May 5, 2020 07:57
@jodator jodator self-requested a review May 5, 2020 09:08
@jodator jodator self-requested a review May 5, 2020 09:12
jodator
jodator suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly code style. Other than that looks good :)

packages/ckeditor5-table/src/tablenavigation.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablenavigation.js Show resolved Hide resolved
packages/ckeditor5-table/src/tableselection.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tableselection.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tableselection.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tableselection.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tableselection.js Show resolved Hide resolved
packages/ckeditor5-table/tests/tableselection.js Show resolved Hide resolved
packages/ckeditor5-table/tests/tableselection.js Outdated Show resolved Hide resolved
@niegowski @jodator
Update packages/ckeditor5-table/tests/tableselection.js
5fe8406 
Co-authored-by: Maciej <jodator@jodator.net>
jodator
jodator reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the test - you could add default value so most of the test code would be left untouched.

packages/ckeditor5-table/src/tablenavigation.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablenavigation.js Outdated Show resolved Hide resolved
jodator
jodator reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

jodator
jodator reviewed May 5, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - I was testing the double comment thing.

@niegowski niegowski requested a review from jodator May 6, 2020 16:50
jodator
jodator suggested changes May 7, 2020
View reviewed changes
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finishing touches :)

packages/ckeditor5-table/src/tableselection.js Outdated Show resolved Hide resolved
packages/ckeditor5-table/src/tablenavigation.js Outdated Show resolved Hide resolved
@niegowski @jodator
Apply suggestions from code review
7aa2f44 
Co-authored-by: Maciej <jodator@jodator.net>
@niegowski niegowski requested a review from jodator May 7, 2020 08:10
@jodator jodator merged commit b567de4 into master May 7, 2020
@niegowski niegowski deleted the i/6115 branch May 7, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jodator jodator jodator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table selection with keyboard Handle Shift+arrows inside table cells
3 participants
@niegowski @jodator @Reinmar