Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention: do not confirm selection on "space" #6394

Closed
fredck opened this issue Mar 9, 2020 · 1 comment · Fixed by #7306
Closed

Mention: do not confirm selection on "space" #6394

fredck opened this issue Mar 9, 2020 · 1 comment · Fixed by #7306
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:mention type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@fredck
Copy link
Contributor

fredck commented Mar 9, 2020

📝 Provide a description of the improvement

Currently, it is cumbersome to simply type text that uses the mention marker but is not in the mention list, in some cases.

For example, suppose this:

  • My app loads just the last 500 issue numbers of CKEditor 5 in the mention list.
  • Let's say we have 1200 issue is total -> therefore issues from 700 to 1200 are loaded.
  • My app uses hash (#) as the marker to mention issues.
  • I want to mention issue 1. I type #1.
    • At this point, the mention list is shown. As the list is filtered by what I typed, I see issues 1000, 1001, 1002... with issue 1000 pre-selected.
  • I want to continuer typing after #1, so I hit space.
    • Issues: my typed #1 is replaced with #1000. That's because space was used to confirm my selection in the list, which is clearly not what I wanted.

This seems to be caused by this line, which tells me that even tab could be used to confirm my select 🤔 
https://github.com/ckeditor/ckeditor5-mention/blob/9a514ccb0dc8b595100fd4459a82fa67cc329d1d/src/mentionui.js#L124

I propose to allow confirming the selected item by using the enter key, exclusively.

📃 Other details

  • CKEditor version: v17.0.0
  • Installed CKEditor plugins: mention

If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@fredck fredck added the type:improvement This issue reports a possible enhancement of an existing feature. label Mar 9, 2020
@fredck
Copy link
Contributor Author

fredck commented Mar 9, 2020

In some senses this is a dup of #4665, with the difference that I find it over-engineering to make this configurable. I'm my POV, allowing space and tab for that purpose was simply a bad design decision to be stripped out.

@mlewand mlewand added this to the backlog milestone Apr 6, 2020
@mlewand mlewand added the domain:ui/ux This issue reports a problem related to UI or UX. label Apr 6, 2020
jodator added a commit that referenced this issue Aug 18, 2020
Other (mention): The space key will not confirm a mention selection from the list. Closes #6394.
@Reinmar Reinmar modified the milestones: backlog, iteration 35 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:mention type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
3 participants